Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SD web-dl support #768

Merged
3 commits merged into from
Nov 4, 2013
Merged

Add SD web-dl support #768

3 commits merged into from
Nov 4, 2013

Conversation

thezoggy
Copy link
Contributor

@thezoggy thezoggy commented Nov 1, 2013

Fixes detection of things like Project.Runway.All.Stars.S03E02.Bitten.By.The.Fashion.Bug.WEB-DL.x264-RKSTR
Cutthroat.Kitchen.S01E03.Tac-o.the.Town.WEB-DL.x264-JIVE

This will pick up mSD's 480 web-dl re-encodes now. Added 480p to ignore_words to stop those for new installs, people can modify if they really want those.

@thezoggy
PEP8 Fixes
bde6c88
@thezoggy
Add SD web-dl support.
53801dd 
Fixes detection of things like `Project.Runway.All.Stars.S03E02.Bitten.By.The.Fashion.Bug.WEB-DL.x264-RKSTR`
`Cutthroat.Kitchen.S01E03.Tac-o.the.Town.WEB-DL.x264-JIVE`
This will pick up mSD's 480 web-dl encodes now. So people may want to add ignore_word for `480p` to stop those.
@thezoggy
Added 480p to ignore_words to prevent mSD re-encodes.
e60df36
ghost pushed a commit that referenced this pull request Nov 4, 2013
Merge pull request #768 from thezoggy/dev--sd_webdl
bda8c30 
Add SD `web-dl` support
@ghost ghost merged commit bda8c30 into midgetspy:development Nov 4, 2013
@bartvandendriessche
Copy link

Is it possible that this introduced a bug where 720p.WEB-DL nzb's are not correctly identified ?

I'm noticing this in my logs:

2013-11-10 21:03:14 DEBUG SEARCHQUEUE-BACKLOG-80379 :: Ignoring result The.Big.Bang.Theory.S07E06.The.Romance.Resonance.720p.WEB-DL because we don't want an episode that is 720p WEB-DL 2013-11-10 21:03:14 DEBUG SEARCHQUEUE-BACKLOG-80379 :: None of the conditions were met so I'm just saying no 2013-11-10 21:03:14 DEBUG SEARCHQUEUE-BACKLOG-80379 :: This quality looks like something we might want but I don't know for sure yet 2013-11-10 21:03:14 DEBUG SEARCHQUEUE-BACKLOG-80379 :: current episode status: 3204 2013-11-10 21:03:14 DEBUG SEARCHQUEUE-BACKLOG-80379 :: sickbeard.db: SELECT status FROM tv_episodes WHERE showid = ? AND season = ? AND episode = ? with args [80379, 7, 6] 2013-11-10 21:03:14 DEBUG SEARCHQUEUE-BACKLOG-80379 :: any,best = [4, 16, 32, 64, 128, 256] [] and we are 32 2013-11-10 21:03:14 DEBUG SEARCHQUEUE-BACKLOG-80379 :: Checking if we want episode 7x6 at quality 720p WEB-DL

@thezoggy
Copy link
Contributor Author

just tried myself, seems to work fine.

14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.720p.WEB-DL is 720p WEB-DL

full results:

14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.720p.WEB-DL.DD5.1.H.264 is 720p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.HDTV.x264-LOL.mp4 is SD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.1080p.WEB-DL.DD5.1.H.264 is 1080p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.HDTV.x264.LOL is SD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.720p.WEB-DL.DD5.1.H.264 is 720p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.1080p.WEB-DL.DD5.1.H.264 is 1080p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.HDTV.x264-LOL is SD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.720p.HDTV.X264-DIMENSION is HD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.720p.WEB-DL is 720p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.1080p.WEB-DL is 1080p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.720p.WEB-DL.DD5.1.H.264 is 720p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.720p.HDTV.X264.VOST-Kharn is HD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.1080p.WEB-DL.DD5.1.H.264 is 1080p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.HDTV.x264-LOL is SD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.720p.WEB-DL is 720p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.1080p.WEB-DL is 1080p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.1080p.WEB-DL.DD5.1.H.264 is 1080p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.HDTV.x264-LOL is SD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.720p.HDTV.X264-DIMENSION is HD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.720p.HDTV.X264-DIMENSION is HD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.720p.WEB-DL.DD5.1.H.264 is 720p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.720p.HDTV.X264.VOST-Kharn is HD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.1080p.WEB-DL is 1080p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.HDTV.x264-LOL is SD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.720p.WEB-DL is 720p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.The.Romance.Resonance.1080p.WEB-DL is 1080p WEB-DL
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.HDTV.x264-LOL is SD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.720p.HDTV.X264-DIMENSION is HD TV
14:58:00 INFO::SEARCHQUEUE-MANUAL-SEARCH :: Quality of The.Big.Bang.Theory.S07E06.720p.HDTV.X264-DIMENSION is HD TV

@thezoggy thezoggy deleted the dev--sd_webdl branch November 20, 2013 21:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thezoggy @bartvandendriessche