CMD_Shows should return both TVDBID and SHOW_NAME regardless of sort order #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midgetspy
added a commit
that referenced
this pull request
Aug 15, 2013
CMD_Shows should return both TVDBID and SHOW_NAME regardless of sort order
thezoggy
added a commit
to thezoggy/Sick-Beard
that referenced
this pull request
Sep 8, 2013
thezoggy
added a commit
to thezoggy/Sick-Beard
that referenced
this pull request
Sep 8, 2013
thezoggy
added a commit
to thezoggy/Sick-Beard
that referenced
this pull request
Sep 8, 2013
gborri
pushed a commit
to gborri/Sick-Beard
that referenced
this pull request
Aug 20, 2014
Return to linux line feeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If making a search using id i.e. '/api/1234/?cmd=shows&sort=id', the return object yields:
which makes parsing the data much more difficult than just including the variables in the return object. With the changes provided, it would allow the return object usable without having to parse through and pull out the 'id' or 'show_name' from a loop.
When making an API call, CMD_Shows returns an object of objects thus making grabbing required information difficult to obtain. These modifications would make of the information available.