Add 1080p and RawHD qualities to SB #564

thezoggy · 2013-01-18T05:32:20Z

Added 1080p aired, 1080p web-dl, 1080i/720p mpeg2 (Raw) qualities
- Adjust CSS/sorting routines to reflect changes, updated quality tags.
- Added .ts to be assumed RawHD quality
Removed 'unknown' as a possible archive quality from the qualityChosser/sb-api/apibuilder

As this creates an bad scenario where an 1080p bluray appear as 'low quality' or even worse could get replaced by some crap mobile friendly release because of 'unkown' having a higher internal value.
SB searches by just the show name if the show has only one season which makes sense until the results contain more than the rss feed limit.

If a show (ex: 'Terra Nova') has 10+ episodes.. so if each ep really came out in the 9 possible qualities (then there is also proper/repacks).. you can easily get over 50 results searching for the show name.. so I added a hack that restores using the S##E## if the show is only one season and has less than 11 episodes total.
Show missing.png on the history page if the provider that was previously used and is no longer in SB/config (deleted/legacy).

…oser/sb-api/apibuilder > As this creates an bad scenario where an 1080p bluray appear as 'low quality' or even worse could get replaced by some crap mobile friendly release because of 'unkown' having a higher internal value. * Added 1080p aired, 1080p web-dl, 1080i/720p mpeg2 (Raw) qualities * Adjust CSS/sorting routines to reflect changes. * Added related CSS for quality tags * Added '.ts' to be assumed RawHD quality

…ich makes sense until the results contain more than the rss feed limit. If a show (ex: 'Terra Nova') has 10+ episodes.. so if each ep really came out in the 9 possible qualities (then there is also proper/repacks).. you can easily get over 50 results searching for the show name.. so I added a hack that restores using the S##E## if the show is only one season and has less than 11 episodes total.

…e quality chooser.

…ously used is no longer in SB/config.

…user 'default' quality along with migrating the previous qualities to their new values. Also PEP8 whitespace fixes.

@midgetspy

… force Download quality. Tighten up check for HD TV and fix 1080p HD TV check @midgetspy - found bug in common.py **nameQuality** regex check does not work if one quality ('HD TV') is part of another quality ('1080p HD TV') thus it gets wrongly matched to (HD TV). For now I changed fullhdtv string to '1080p HDTV' to bypass this for now. Possible fix is to change 'HD TV' to '720p HD TV' so it follows similar naming of web-dl/bluray.. but the negative is that everyones previous names wouldnt be right/match/need to be updated... or we change how the regex matches...

mtakacs · 2013-01-26T22:32:25Z

+1 , was hoping this was on deck somewhere..

pokonski · 2013-01-27T16:15:05Z

mtakacs · 2013-01-27T22:01:52Z

nice duck!

…is actually used on SBConnect or any app for that matter.. so shouldn't break anything. > The SB quality templates can change and we do not want people submitting a template name but rather use the quality makeup. (ex, sdtv/sddvd for SD). This way it protects people from us changing things with the templates as the app coders can still just submit what they want SD to be / handle legacy qualities easier. (if sb.api = 3 then HD is this... if its 4 then HD is now this...)

nberlee · 2013-02-03T23:08:11Z

@thezoggy Netflix only series like the House of Cards have WEBrip, which I think should be treated as web.dl in sickbeard

thezoggy · 2013-02-04T03:06:29Z

This is already discussed internally.. And will be handle post merge

-----Original Message-----
From: "Nico Berlee" notifications@github.com
Sent: ‎2/‎3/‎2013 5:08 PM
To: "midgetspy/Sick-Beard" Sick-Beard@noreply.github.com
Cc: "thezoggy" thezoggy@gmail.com
Subject: Re: [Sick-Beard] Add 1080p and RawHD qualities to SB (#564)

@thezoggy Netflix only series like the House of Card have WEBrip, which I think should be treated as web.dl in sickbeard

Reply to this email directly or view it on GitHub:
#564 (comment)

mtakacs · 2013-02-04T04:17:43Z

This is already discussed internally.. And will be handle post merge

awesome! Can't wait for this to land. :)

marcusds · 2013-02-05T04:09:38Z

awesome! Can't wait for this to land. :)

Seconded!

junalmeida · 2013-02-09T14:36:48Z

Will this ever be merged?

Skindred · 2013-02-09T16:37:17Z

The code has been tested, and found stable, in many other peoples forks.
I think that the time has arrived to merge this.
But that's what I think :)

nifoc · 2013-02-09T18:32:20Z

The lack of communication on this, once again, makes me a really sad panda.

If something is not okay with this PR, why not let people know so that the community is able to help?

thezoggy · 2013-02-09T22:10:17Z

People have lives. And dev telated talk happens internally on IRC.. Not on github.

-----Original Message-----
From: "Daniel Kempkens" notifications@github.com
Sent: ‎2/‎9/‎2013 12:32 PM
To: "midgetspy/Sick-Beard" Sick-Beard@noreply.github.com
Cc: "thezoggy" thezoggy@gmail.com
Subject: Re: [Sick-Beard] Add 1080p and RawHD qualities to SB (#564)

The lack of communication on this, once again, makes me a really sad panda.

If something is not okay with this PR, why not let people know so that the community is able to help?

Reply to this email directly or view it on GitHub:
#564 (comment)

nifoc · 2013-02-09T22:56:56Z

People have lives.

Which is why OSS is so great. The community can help and not take away too much time from one developer. But …

And dev telated talk happens internally on IRC

… is kinda working directly against this. I bet I'm not the only one who would love to help make SickBeard even better, but I'm not really able to, or am I?

nberlee · 2013-02-09T23:05:42Z

This kind of unopeness is a reason for me never to open a pull request here again like I did a few times in the past. This cuts people off, and really doesn't motivate them to participate in any way.

enigma2k · 2013-02-10T00:31:13Z

what's a good fork with frequent updates that has this already included?

simonk83 · 2013-02-10T00:32:09Z

Pretty much. As I've said before, SB isn't really an open project as
others are, it's more of a dictatorship really :). Not to take anything
away from the 3 or so devs that make all the decisions, as SB is generally
nice and stable, however I do think its nowhere close to being as good as
it could be as the majority of the most popular and requested pull requests
are left to idle as one of the few people with decision making abilities
decides its "not important to them" or whatever.

Again, I love the app, it's amazing, but the work ethic behind it is all
wrong IMO.

On Sunday, February 10, 2013, Nico Berlee wrote:

This kind of unopeness is a reason for me never to open a pull request
here again like I did a few times in the past. This cuts people off, and
really doesn't motivate them to participate in any way.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/564#issuecomment-13340606..

thezoggy · 2013-02-10T01:31:15Z

there are several forks.. there are several people that have taken it upon themselves to take sb in the direction they want. yes, midget's repo is solely controlled by him and no one else can push out updates... but honestly most people wouldnt be qualified to push out updates as there is a lot of spaghetti code that only he knows/understands/wrote. even on some of the most simple pull requests people have broken parts of sb because they were not paying close enough attention or knew how python worked. my comments were not to push people way but to set expectations. recently we've had a number of people willing to contribute and ive worked with them personally to get things updated and fixed (nzbsrus/nzbx.co/etc) now the ball is in midget's court to code review/accept them. which is going to have to be on his time since well.. it is his repo after all. if i break something.. he has to deal with the cleanup... so one could hope you would see why hes a bit careful on including code.

mtakacs · 2013-02-21T20:46:16Z

@thezoggy thanks for the glimpse into the behind-scenes-workings...

midgetspy · 2013-02-23T19:32:54Z

Pulled

nifoc · 2013-02-23T19:41:06Z

So, how long does it usually take for the development branch to be merged back into master?

thezoggy · 2013-02-23T23:54:47Z

generally we try to stick to a 1month cycle. we are running a little behind but are working on updates if you havent noticed :)

madburg · 2013-02-24T16:24:17Z

Will this "Add 1080p and RawHD qualities to SB" make it into the Windows binary soon? It would be most appreciated. Thanks for all your work!

thezoggy · 2013-02-24T18:55:57Z

just keep an eye out on the changelog for whats in dev (which is whats going to be in the next windows binary)
https://github.com/midgetspy/Sick-Beard/wiki/ChangeLog

madburg · 2013-02-24T19:01:46Z

Thanks for the reply back! So its not there yet in dev, or am I missing something? This one is dear to my heart as so much is coming in 1080p WEB-DL and a few shows that only come in RAW. Appreciate all that you can do to make this happen and make its way to the win binary. Nothing short of an awesome app!

joel-daros · 2013-03-02T15:06:53Z

Definitely needs a setting for the 1080p WEB DL

thezoggy · 2013-03-02T20:16:18Z

@MrSparklle 1080p web-dl is there.. along with 1080p hdtv and 720p/1080i rawhd (mpeg2)

madburg · 2013-03-02T20:41:49Z

Cant wait for the new Windows Build, thanks thezoggy!

nifoc · 2013-03-16T20:31:49Z

It's been another three weeks: Anything on when the next master<-development merge will happen?

midgetspy · 2013-03-19T04:20:22Z

Probably within a week or so.

Fix RTorrent client

thezoggy added 6 commits December 29, 2012 04:32

Visually suggest that the HD template contains HD1080p + HD720p in th…

86fdcf0

…e quality chooser.

Show missing.png on the history page if the provider that was previ…

5aa3b58

…ously used is no longer in SB/config.

Added Add1080pAndRawHDQualities migration code. This will update the …

c0d376c

…user 'default' quality along with migrating the previous qualities to their new values. Also PEP8 whitespace fixes.

thezoggy mentioned this pull request Jan 27, 2013

Changes to allow for 1080p WEB-DLs #499

Closed

midgetspy closed this Feb 23, 2013

Prinz23 pushed a commit to Prinz23/Sick-Beard that referenced this pull request Feb 21, 2014

Merge pull request midgetspy#564 from rgaiser/ThePirateBay

44a6ccc

Fix RTorrent client

thezoggy deleted the dev--new_1080p branch April 12, 2014 23:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 1080p and RawHD qualities to SB #564

Add 1080p and RawHD qualities to SB #564

thezoggy commented Jan 18, 2013

mtakacs commented Jan 26, 2013

pokonski commented Jan 27, 2013

mtakacs commented Jan 27, 2013

nberlee commented Feb 3, 2013

thezoggy commented Feb 4, 2013

mtakacs commented Feb 4, 2013

marcusds commented Feb 5, 2013

junalmeida commented Feb 9, 2013

Skindred commented Feb 9, 2013

nifoc commented Feb 9, 2013

thezoggy commented Feb 9, 2013

nifoc commented Feb 9, 2013

nberlee commented Feb 9, 2013

enigma2k commented Feb 10, 2013

simonk83 commented Feb 10, 2013

thezoggy commented Feb 10, 2013

mtakacs commented Feb 21, 2013

midgetspy commented Feb 23, 2013

nifoc commented Feb 23, 2013

thezoggy commented Feb 23, 2013

madburg commented Feb 24, 2013

thezoggy commented Feb 24, 2013

madburg commented Feb 24, 2013

joel-daros commented Mar 2, 2013

thezoggy commented Mar 2, 2013

madburg commented Mar 2, 2013

nifoc commented Mar 16, 2013

midgetspy commented Mar 19, 2013

Add 1080p and RawHD qualities to SB #564

Add 1080p and RawHD qualities to SB #564

Conversation

thezoggy commented Jan 18, 2013

mtakacs commented Jan 26, 2013

pokonski commented Jan 27, 2013

mtakacs commented Jan 27, 2013

nberlee commented Feb 3, 2013

thezoggy commented Feb 4, 2013

mtakacs commented Feb 4, 2013

marcusds commented Feb 5, 2013

junalmeida commented Feb 9, 2013

Skindred commented Feb 9, 2013

nifoc commented Feb 9, 2013

thezoggy commented Feb 9, 2013

nifoc commented Feb 9, 2013

nberlee commented Feb 9, 2013

enigma2k commented Feb 10, 2013

simonk83 commented Feb 10, 2013

thezoggy commented Feb 10, 2013

mtakacs commented Feb 21, 2013

midgetspy commented Feb 23, 2013

nifoc commented Feb 23, 2013

thezoggy commented Feb 23, 2013

madburg commented Feb 24, 2013

thezoggy commented Feb 24, 2013

madburg commented Feb 24, 2013

joel-daros commented Mar 2, 2013

thezoggy commented Mar 2, 2013

madburg commented Mar 2, 2013

nifoc commented Mar 16, 2013

midgetspy commented Mar 19, 2013