Notifiers: XBMC / Plex - cleanup and update #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thezoggy
commented
Nov 7, 2012
thezoggy
commented
- XBMC notifier was completely redone to support both the legacy http api and the upcoming xbmc12 (frodo) json-rpc method. Using the public calls as wrappers with the detection to know which internal methods to call.
- Due to the XBMC rewrite, the Plex notifier no longer inherits xbmc's notifier as the code has diverged too much -- plus we were wrongly showing 'xbmc' log messages.
- Cleaned up many small bugs I found in the process as well as updated the config ui notification page.
- Cleaned up the notifiers page to match the web ui, which made it easier to test and for others to add notifiers in the future.
…--xbmc_json_cleanup
…d in testing changes), fixed notifio from being done out of order (was missing from the internal notifiers list).
…heckbox). Document NMJ's abnormal library routine to fire on notify_download rather than when doing a library update. Prob will fix this when I go back through all the notifiers to fix the numerous bugs I've discovered.
…I or the newer JSON-RPC API when applicable. Cleaned up the config notifications and test functions response to better handle multiple hosts. Now we only send the library update commands to the FIRST xbmc host listed if there are multiple servers provided. This was needed to keep SB from messing up XBMC setups that use sql.
|
With XBMC the 20121108 3b7a2ab nightly, was able to send a test notification to XBMC successfully. |
midgetspy
added a commit
that referenced
this pull request
Nov 15, 2012
Notifiers: XBMC / Plex - cleanup and update
This was referenced Nov 21, 2012
|
This works great. Well done. When will this be added to the master branch? |
|
when we are ready to push out a new build.. not too much longer.. but we have some bugs to fix by other recent code submissions first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.