Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no dir manual postprocessing #408

Merged
merged 1 commit into from Aug 27, 2012
Merged

Fix no dir manual postprocessing #408

merged 1 commit into from Aug 27, 2012

Conversation

ghost
Copy link

@ghost ghost commented Jun 9, 2012

When no folder is supplied in webinterface Manual postprocessing, dir is not None but ''

@@ -1541,7 +1541,7 @@ def index(self):
@cherrypy.expose
def processEpisode(self, dir=None, nzbName=None, jobName=None, quiet=None):

if dir == None:
if dir == None or dir == '':
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be "if not dir" which covers both cases. Good catch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered changing it to "if not dir" first, but thought we don't want 'dir = True' to enter processTV.processDir either.

But I'll change it.

When no folder is supplied in webinterface, dir is not None but ''
Combine dir == None or dir == '' to not dir
midgetspy added a commit that referenced this pull request Aug 27, 2012
@midgetspy midgetspy merged commit 6dcc2a6 into midgetspy:development Aug 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant