Pushover notifications #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why not squash your commits to 1. no need to close and pull request.. just squash and force push. btw maybe next time try submitting pull request when its ready? |
|
yeah, my testing method wasn't all that good.. I will squash next time ( didn't know about it till now :D ). |
|
no worries. we just have so many pull requests. that sometimes it takes a few people to test before we it will be considered to be pulled into master. just trying to help keep things a bit cleaner so our changelogs are so gross :) |
commiting changes pushover notifications working fixed missing param / made test use key pass userKey from webserv / spelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time with 100% more working!