Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stream): connecting errors not being handled correctly #92

Merged
merged 1 commit into from
Dec 3, 2022
Merged

fix(stream): connecting errors not being handled correctly #92

merged 1 commit into from
Dec 3, 2022

Conversation

microwavekonijn
Copy link
Owner

When destroy was called before any connection was established it would thrown an uncaught exception, due to the lack of an error listener.

@microwavekonijn microwavekonijn added the bug Something isn't working label Dec 3, 2022
@microwavekonijn microwavekonijn self-assigned this Dec 3, 2022
@microwavekonijn microwavekonijn temporarily deployed to test December 3, 2022 23:11 Inactive
@microwavekonijn microwavekonijn merged commit 465b4e6 into master Dec 3, 2022
@microwavekonijn microwavekonijn deleted the fix/error-close-connection branch December 3, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@microwavekonijn microwavekonijn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@microwavekonijn