Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release Configuration. #2593

Merged
merged 5 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .azure-pipelines/ci-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -261,17 +261,15 @@ extends:
nuGetFeedType: external
publishFeedCredentials: 'microsoftgraph NuGet connection'
- task: GitHubRelease@1
displayName: 'GitHub release (create)'
displayName: 'GitHub release (Upload Artifacts)'
inputs:
gitHubConnection: 'Kiota_Release'
target: $(Build.SourceVersion)
action: edit
tagSource: userSpecifiedTag
tag: 'v$(VERSION_STRING)'
title: '$(VERSION_STRING)'
releaseNotesSource: inline
title: 'v$(VERSION_STRING)'
assets: |
!**/**
$(Pipeline.Workspace)/Microsoft.Graph.*.*nupkg
changeLogType: issueBased
isPreRelease: '$(IS_PRE_RELEASE)'
addChangeLog: true
addChangeLog: false
38 changes: 1 addition & 37 deletions .github/policies/msgraph-sdk-dotnet-branch-protection.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,45 +37,9 @@ configuration:
requiredStatusChecks:
- build
- license/cla
# Require branches to be up to date before merging. Requires requiredStatusChecks. boolean
# Require branches to be up-to-date before merging. Requires requiredStatusChecks. boolean
requiresStrictStatusChecks: true
# Indicates whether there are restrictions on who can push. boolean. Should be set with whoCanPush.
restrictsPushes: false
# Restrict who can dismiss pull request reviews. boolean
restrictsReviewDismissals: false

- branchNamePattern: dev
# This branch pattern applies to the following branches as of 06/12/2023 10:31:13:
# dev

# Specifies whether this branch can be deleted. boolean
allowsDeletions: false
# Specifies whether forced pushes are allowed on this branch. boolean
allowsForcePushes: false
# Specifies whether new commits pushed to the matching branches dismiss pull request review approvals. boolean
dismissStaleReviews: true
# Specifies whether admins can overwrite branch protection. boolean
isAdminEnforced: false
# Indicates whether "Require a pull request before merging" is enabled. boolean
requiresPullRequestBeforeMerging: true
# Specifies the number of pull request reviews before merging. int (0-6). Should be null/empty if PRs are not required
requiredApprovingReviewsCount: 1
# Require review from Code Owners. Requires requiredApprovingReviewsCount. boolean
requireCodeOwnersReview: true
# Are commits required to be signed. boolean. TODO: all contributors must have commit signing on local machines.
requiresCommitSignatures: false
# Are conversations required to be resolved before merging? boolean
requiresConversationResolution: true
# Are merge commits prohibited from being pushed to this branch. boolean
requiresLinearHistory: false
# Required status checks to pass before merging. Values can be any string, but if the value does not correspond to any existing status check, the status check will be stuck on pending for status since nothing exists to push an actual status
requiredStatusChecks:
- build
- license/cla
# Require branches to be up to date before merging. Requires requiredStatusChecks. boolean
requiresStrictStatusChecks: true
# Indicates whether there are restrictions on who can push. boolean. Should be set with whoCanPush.
restrictsPushes: false
# Restrict who can dismiss pull request reviews. boolean
restrictsReviewDismissals: false

6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ Thanks for considering making a contribution! Read over our guidelines and we wi
There are a few different recommended paths to get contributions into the released version of this library.

## File issues
The best way to get started with a contribution is to start a dialog with us. Sometimes features will be under development or out of scope for this library and it's best to check before starting work on contribution, especially for large work items.
The best way to get started with a contribution is to start a dialog with us. Sometimes features will be under development or out of scope for this library, and it's best to check before starting work on contribution, especially for large work items.

## Pull requests
All pull requests should be submitted against the **dev** branch or a specific feature branch. The master branch is intended to represent the code released in the most-recent Nuget package.
All pull requests should be submitted against the **master** branch or a specific feature branch. The master branch is intended to represent the code released in the most-recent Nuget package.

## Commit message format

Expand Down Expand Up @@ -42,7 +42,7 @@ The recommended commit types used are:

Adding a footer with the prefix **BREAKING CHANGE:** will cause an increment of the _major_ version.

When a new package is about to be released, changes in dev will be merged into master. The package will be generated from master.
When a new package is about to be release, the release PR will be merged into master. The package will be generated from master.

Some things to note about this project:

Expand Down
4 changes: 2 additions & 2 deletions release-please-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
".github",
".vscode"
],
"release-type": "dotnet",
"release-type": "simple",
"include-component-in-tag": false,
"include-v-in-tag": true,
"packages": {
Expand All @@ -15,7 +15,7 @@
"changelog-path": "CHANGELOG.md",
"extra-files": [
"README.md",
"src/Microsoft.Graph.csproj"
"src/Microsoft.Graph/Microsoft.Graph.csproj"
]
}
},
Expand Down
63 changes: 0 additions & 63 deletions scripts/IncrementMinorVersion.ps1

This file was deleted.

106 changes: 0 additions & 106 deletions scripts/generateTypeSummary.ps1

This file was deleted.

Loading