Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed keyword beta from v1.0 service reference #1829

Merged
merged 2 commits into from
May 30, 2023
Merged

Removed keyword beta from v1.0 service reference #1829

merged 2 commits into from
May 30, 2023

Conversation

cjvandyk
Copy link
Contributor

Changed "The beta v1.0 service" to "The v1.0 service".

Fixes #

Changes proposed in this pull request

  • Changed "The beta v1.0 service" to "The v1.0 service" to prevent ambiguity and user confusion since the next line reads "The beta service".

Other links

@cjvandyk
Removed keyword beta from v1.0 service reference
437c227 
Changed "The beta v1.0 service" to "The v1.0 service".
baywet
baywet previously approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@baywet baywet enabled auto-merge April 17, 2023 14:53
@andrueastman
Copy link
Member

Thanks for raising this @cjvandyk

Any chance you can rebase the PR to target the dev branch rather than the feature/5.0 branch?

@andrueastman andrueastman changed the base branch from feature/5.0 to dev May 30, 2023 11:49
@andrueastman andrueastman dismissed baywet’s stale review May 30, 2023 11:49

The base branch was changed.

@andrueastman andrueastman requested a review from a team as a code owner May 30, 2023 11:49
@baywet baywet merged commit 5a55be9 into microsoftgraph:dev May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet baywet left review comments

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjvandyk @andrueastman @baywet