Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for operations bound to directoryObjects/deletedItems #451

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Oct 4, 2023

Closes #449

Adds Org.OData.Core.V1.ExplicitOperationBinding and Org.OData.Core.V1.RequiresExplicitBinding annotations to functions bound to directory objects type to unlock generation of functions/actions on /deletedItems path

Depends on release of microsoft/OpenAPI.NET.OData#430

@andrueastman
Copy link
Member Author

Validation notes
This PR ends up dropping functions/actions listed above in the following navigation properties paths that are of the type directoryObject paths in the final openApi metadata which looks to be valid given the testing and available documentation leading to some path reduction.

  1. /groups/{group-id}/permissionGrants - No supporting docs and queries fail on GE. Can only be listed according to the docs. Contains target is true.
  2. /teams/{group-id}/permissionGrants - No supporting docs and queries fail on GE. Can only be listed according to the docs. Contains target is true.
  3. /chats/{group-id}/permissionGrants - No supporting docs and queries fail on GE. Can only be listed according to the docs. Contains target is true.
  4. /identityGovernance/entitlementManagement/connectedOrganizations/{id}/externalSponsors - No supporting docs and queries fail on GE. Can only Add, list and delete. Should probably have contains target as false?.
  5. /identityGovernance/entitlementManagement/connectedOrganizations/{id}/internalSponsors - No supporting docs and queries fail on GE. Can only Add, list and delete. Should probably have contains target as false? . Similar to externalSponsors above in 4.
  6. /policies/appManagementPolicies/{id}/appliesTo - No supporting docs and ContainsTarget is false. Ideally functions/actions should not be bound to references.

@andrueastman andrueastman marked this pull request as ready for review October 5, 2023 10:39
@andrueastman andrueastman requested a review from a team as a code owner October 5, 2023 10:39
@andrueastman andrueastman self-assigned this Oct 5, 2023
baywet
baywet previously requested changes Oct 5, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also set the internal and external sponsors to contains target false since
https://learn.microsoft.com/en-us/graph/api/connectedorganization-post-internalsponsors?view=graph-rest-1.0&tabs=http uses a $ref to add a sponsor.

@andrueastman
Copy link
Member Author

Let's also set the internal and external sponsors to contains target false since https://learn.microsoft.com/en-us/graph/api/connectedorganization-post-internalsponsors?view=graph-rest-1.0&tabs=http uses a $ref to add a sponsor.

Agreed. Resolved in latest update

@andrueastman andrueastman requested a review from baywet October 5, 2023 14:23
@andrueastman andrueastman dismissed baywet’s stale review October 5, 2023 14:24

Changes addressed in latest update

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@andrueastman andrueastman merged commit 822dde4 into master Oct 5, 2023
24 checks passed
@andrueastman andrueastman deleted the andrueastman/fixRestore branch October 5, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DirectoryObject bound operations not generated on /directory/deletedItems
2 participants