Feature: Enable loading of samples and Permissions descriptions files from Github #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he query string and append them to devxapi object
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-829.centralus.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-829.centralus.azurestaticapps.net |
thewahome
reviewed
Feb 4, 2021
thewahome
reviewed
Feb 4, 2021
thewahome
reviewed
Feb 4, 2021
thewahome
reviewed
Feb 4, 2021
thewahome
reviewed
Feb 4, 2021
…ature/samples-testing
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-829.centralus.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-829.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-829.centralus.azurestaticapps.net |
thewahome
approved these changes
Feb 8, 2021
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-829.centralus.azurestaticapps.net |
MaggieKimani1
added a commit
that referenced
this pull request
Feb 8, 2021
…esting" This reverts commit 220bacb.
MaggieKimani1
added a commit
that referenced
this pull request
Feb 8, 2021
* Check for devxApiUrl override, fetch org and branchName params from the query string and append them to devxapi object * Change response type to object * Create an initialState object and pass it to state * Add check for devxapi params and append them to samplesUrl * Check for devxapi params and append them to the permissionsUrl * Create an IDevxAPI interface * Import IDevxAPI from types and reference it * Import and reference IAction from the types folder * Rename the devx-api types file * Use ternary operator to simplify conditional statement * Revert "Merge pull request #829 from microsoftgraph/feature/samples-testing" This reverts commit 220bacb.
MaggieKimani1
added a commit
that referenced
this pull request
Feb 8, 2021
…amples-testing"" This reverts commit 2839dce.
MaggieKimani1
added a commit
that referenced
this pull request
Feb 9, 2021
* Check for devxApiUrl override, fetch org and branchName params from the query string and append them to devxapi object * Change response type to object * Create an initialState object and pass it to state * Add check for devxapi params and append them to samplesUrl * Check for devxapi params and append them to the permissionsUrl * Create an IDevxAPI interface * Import IDevxAPI from types and reference it * Import and reference IAction from the types folder * Rename the devx-api types file * Use ternary operator to simplify conditional statement * Revert "Merge pull request #829 from microsoftgraph/feature/samples-testing" This reverts commit 220bacb. * Revert "Revert "Merge pull request #829 from microsoftgraph/feature/samples-testing"" This reverts commit 2839dce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR proposes adding of testing functionality for samples and permissions descriptions files in the DevX Content repo
Testing Instructions
Run Graph Explorer locally on your machine
Clone https://github.com/microsoftgraph/microsoft-graph-explorer-api and Run DevX API locally
Override fetching from blob storage by calling and supplying org and branchName params to the devx-api query string
http://localhost:3000/?devx-api=https://localhost:5001&org=mg&branchName=devThe call should return a set of samples and permissions from the DevX Content repo