Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: expand maxWidth allow more humanName chars #764

Merged
merged 11 commits into from
Feb 12, 2021
Merged

Fix: expand maxWidth allow more humanName chars #764

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d91008c
add maxwidth stretch to 300 instead of 180 in columns
ezkemboi Nov 16, 2020
3c7dc00
make maxWidth for humanName dynamic
ezkemboi Nov 17, 2020
ea46ede
Merge branch 'dev' into issue-694
ezkemboi Nov 17, 2020
74c4d76
Merge branch 'dev' into issue-694
ezkemboi Nov 21, 2020
cc61d59
allow window resize listener
ezkemboi Nov 21, 2020
ba79298
merge upstream/dev
ezkemboi Jan 15, 2021
4f9d4fe
lint
ezkemboi Jan 15, 2021
f0420a4
Merge branch 'dev' into issue-694
ezkemboi Jan 18, 2021
09065c1
Merge branch 'dev' into issue-694
ezkemboi Jan 20, 2021
579fa08
Merge branch 'dev' into issue-694
ezkemboi Jan 29, 2021
914cfe4
Merge branch 'dev' into issue-694
ezkemboi Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/app/views/sidebar/sample-queries/SampleQueries.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,17 @@ export class SampleQueries extends Component<ISampleQueriesProps, any> {
);
}

let maxWidthOfHumanName = 180;
if (window.innerWidth > 1280) {
maxWidthOfHumanName = 300;
}

window.onresize = () => {
if (window.innerWidth > 1280) {
maxWidthOfHumanName = 300;
}
};

const columns = [
{
key: 'authRequiredIcon',
Expand All @@ -376,7 +387,7 @@ export class SampleQueries extends Component<ISampleQueriesProps, any> {
name: '',
fieldName: 'humanName',
minWidth: 100,
maxWidth: 180,
maxWidth: maxWidthOfHumanName,
},
{
key: 'button',
Expand Down