Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove main tag #680

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Remove main tag #680

merged 2 commits into from
Sep 1, 2020

Conversation

ElinorW
Copy link
Contributor

@ElinorW ElinorW commented Sep 1, 2020

Overview

Removed the

tags as Graph explorer already contains another main landmark
Fixes #647

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@ElinorW ElinorW requested a review from thewahome September 1, 2020 15:59
thewahome
thewahome approved these changes Sep 1, 2020
View reviewed changes
Copy link
Collaborator

@thewahome thewahome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElinorW ElinorW merged commit 5e634dd into dev Sep 1, 2020
@ElinorW ElinorW deleted the fix/accessibility-support branch September 1, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewahome thewahome thewahome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the use of <main> on Graph Explorer as there is already another main landmark.
2 participants
@ElinorW @thewahome