Add CI perf summary #786
Add CI perf summary #786
Conversation
| Average = $Metric.Value | Measure-Object -Average | Select-Object -ExpandProperty Average | ||
| Minimum = $Metric.Value | Measure-Object -Minimum | Select-Object -ExpandProperty Minimum | ||
| Maximum = $Metric.Value | Measure-Object -Maximum | Select-Object -ExpandProperty Maximum |
There was a problem hiding this comment.
Let's cast these to integers to drop the fractions. They just make the table harder to read.
There was a problem hiding this comment.
I agree they're ugly and need more work, but I don't want to cast away values that could be 0.x.
| ScenarioName = $_.Key.ScenarioName | ||
| Platform = $_.Key.Platform | ||
| CommitHash = $_.Key.CommitHash | ||
| MetricName = $Metric.Key |
There was a problem hiding this comment.
Personally, I don't think this is useful since all of them are the same (pps), but if you really need to keep it, I recommend using Units instead of MetricName.
There was a problem hiding this comment.
We'll add more metrics later - we obviously should have CPU usage, and perhaps drops, memory usage, etc.
There was a problem hiding this comment.
Different metrics may have the same units - e.g. CPU% and RAM% are both units of per cent.
| [pscustomobject]@{ | ||
| ScenarioName = $_.Key.ScenarioName | ||
| Platform = $_.Key.Platform | ||
| CommitHash = $_.Key.CommitHash |
There was a problem hiding this comment.
Can we use the short hash instead of the full one?
There was a problem hiding this comment.
I agree that would be more readable formatting
Description
Describe the purpose of and changes within this Pull Request.
Summarize all performance data in a CI run onto a single page.
Testing
Do any existing tests cover this change? Are new tests needed?
CI.
Documentation
Is there any documentation impact for this change?
No.
Installation
Is there any installer impact for this change?
No.