Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinScreenfetch added #805

Closed
wants to merge 2 commits into from
Closed

WinScreenfetch added #805

wants to merge 2 commits into from

Conversation

sebagomez
Copy link

@sebagomez sebagomez commented May 22, 2020

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

sebagomez The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@sebagomez
Copy link
Author

The manifest was created using the Windows Store tool.
Also, it is just a plain exe with no installation, do I still need to wrap it in an installer?

@ghost ghost removed the Needs: author feedback label May 24, 2020
addressed manifest issue
@wingetbot wingetbot removed the Manifest-Validation-Error Manifest validation failed label Jul 12, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 12, 2020
@ghost ghost assigned KevinLaMS Jul 12, 2020
@ghost
Copy link

ghost commented Jul 12, 2020

This submission has moved to manual review.

@qiancy98 qiancy98 mentioned this pull request Jul 18, 2020
@KevinLaMS KevinLaMS added the Validation-Error General Error during testing. Requires we provide comment to author. label Jul 20, 2020
@ghost
Copy link

ghost commented Jul 20, 2020

sebagomez An issue was identified during the manual review, and the PR request cannot be approved. Please see comments for more information.
Please address the issue and resubmit, or if you disagree with this resolution, please raise an issue and flag this PR for further discussion.

@ghost ghost assigned sebagomez Jul 20, 2020
@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jul 20, 2020
@KevinLaMS
Copy link
Contributor

This does not seem to install.
From what I can tell, this is an EXE that runs rather than installs.

@sebagomez
Copy link
Author

It is, it does not have an installer. Must it have one? Could it be a powershell script that does the "installation"?

@ghost ghost removed the Needs: author feedback label Jul 23, 2020
@denelon denelon added the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 28, 2020
@denelon
Copy link
Contributor

denelon commented Jul 28, 2020

@sebagomez we don't have support for "stand alone installers" yet. microsoft/winget-cli#182

@denelon denelon added the .exe label May 4, 2021
@denelon
Copy link
Contributor

denelon commented May 4, 2021

We need to implement support for standalone executables, and the schema needs to be updated.

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 11, 2021
@ghost
Copy link

ghost commented May 11, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this May 18, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Error General Error during testing. Requires we provide comment to author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants