Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SumatraPDF v3.2 #346

Merged
3 commits merged into from
Jun 17, 2020
Merged

Add SumatraPDF v3.2 #346

3 commits merged into from
Jun 17, 2020

Conversation

drproteus
Copy link
Contributor

@drproteus drproteus commented May 19, 2020

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@msftclas
Copy link

msftclas commented May 19, 2020

CLA assistant check
All CLA requirements met.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 19, 2020
@ghost ghost assigned denelon May 19, 2020
@ghost
Copy link

ghost commented May 19, 2020

This submission has moved to manual review.

@denelon
Copy link
Contributor

denelon commented May 20, 2020

@drproteus did you install Sumatra on your local machine with the manifest. I got an error that looks like a "remove:" failed. This may be the difference in user mode vs. admin mode. It looks like it did install, but I'd like to make sure we're providing the best experience we can for users.

@drproteus
Copy link
Contributor Author

@denelon I must be too used to apt land because I immediately thought I was doing something wrong when I got the error in a user terminal, so I ran it in an elevated prompt. It seems like winget is trying to delete the temp installer before its done being executed. Not sure if its at all related to microsoft/winget-cli#189.

@ghost ghost removed the Needs: author feedback label May 20, 2020
@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label May 21, 2020
@KevinLaMS
Copy link
Contributor

This is blocked on Issue microsoft/winget-cli#189

@ghost ghost mentioned this pull request May 31, 2020
@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Jun 17, 2020
@ghost
Copy link

ghost commented Jun 17, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 9992064 into microsoft:master Jun 17, 2020
@GitHubRulesOK
Copy link

GitHubRulesOK commented Mar 21, 2021

The command line is incorrect the fileNAME-install.exe is the trigger and the silent option was /s (small) it will likely be -s in the next release but there are other considerations such as allow the multi user administrator to specify /d (destination will become -d) the current default is users LocalAppdata NOT to be the ADMIN/Installer LocalAppdata

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants