Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metro Commander version 1.3.87.0 #18164

Closed
wants to merge 5 commits into from

Conversation

ValeraFinebits
Copy link
Contributor

@ValeraFinebits ValeraFinebits commented Jun 20, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jun 20, 2021
@ghost
Copy link

ghost commented Jun 20, 2021

Hello @ValeraFinebits,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 20, 2021
@ValeraFinebits
Copy link
Contributor Author

Where can I find logs to find out what the problem is?

@ghost ghost added Needs: Attention and removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 20, 2021
@OfficialEsco
Copy link
Contributor

[X] Have you tested your manifest locally with winget install --manifest ?

PS C:\Users\Esco\Downloads> winget install -m M:\f\Finebits\MetroCommander\1.3.87.0\
Found Metro Commander [Finebits.MetroCommander]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://finebitsstorage.z22.web.core.windows.net/metrocommander/packages/MC_1.3.87.0.msix
  ██████████████████████████████   106 MB /  106 MB
Successfully verified installer hash
Starting package install...
  ██████████████████████████████  0%
Install failed: Windows cannot install package BOOSTUDIOLLC.METROCOMMANDER_1.3.87.0_x86__b6e429xa66pga because this package depends on a framework that could not be found. Provide the framework "Microsoft.UI.Xaml.2.3" published by "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x86 processor architecture and minimum version 2.31912.11002.0, along with this package to install. The frameworks with name "Microsoft.UI.Xaml.2.3" currently installed are: {}
0x80073cf3 : Package failed updates, dependency or conflict validation.

Just tested the 1.3.86.0 Manifest and it seems to have the same issue

PS C:\Users\Esco\Downloads> winget install -m M:\f\Finebits\MetroCommander\1.3.86.0\
Found Metro Commander [Finebits.MetroCommander]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://finebitsstorage.z22.web.core.windows.net/metrocommander/packages/MC_1.3.86.0.msix
  ██████████████████████████████   189 MB /  189 MB
Successfully verified installer hash
Starting package install...
  ██████████████████████████████  0%
Install failed: Windows cannot install package BOOSTUDIOLLC.METROCOMMANDER_1.3.86.0_x64__b6e429xa66pga because this package depends on a framework that could not be found. Provide the framework "Microsoft.UI.Xaml.2.3" published by "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x64 processor architecture and minimum version 2.31912.11002.0, along with this package to install. The frameworks with name "Microsoft.UI.Xaml.2.3" currently installed are: {}
0x80073cf3 : Package failed updates, dependency or conflict validation.

This was detected in #621 but it somehow got approved AFTER adding the Validation-MSIX-Dependency label..

@ValeraFinebits
Copy link
Contributor Author

Yes, I tested. It perfectly working locally.

@OfficialEsco
Copy link
Contributor

Yes, I tested. It perfectly working locally.

You're not wrong, it says locally... Should get changed to VM/Sandbox or properly tested..

When you manually run the installer it installs Microsoft Engagement Framework and Microsoft.UI.Xaml.2.3
image
however when you do it from command prompt it doesn't

Also you did get a answer from a technician #16142 (comment)

@ValeraFinebits
Copy link
Contributor Author

I deleted Microsoft.Advertising.Xaml, but I can't remove the dependence on Microsoft.UI.Xaml.
What can I do to install Microsoft.UI.Xaml with winget?

@OfficialEsco
Copy link
Contributor

microsoft/winget-cli#163
And you need to add Dependency's in the Installer Manifest, since its not supported yet we have no documentation on how to do Packages outside of the Winget Pkgs Repo

"Dependencies": {
      "type": [ "object", "null" ],
      "properties": {
        "WindowsFeatures": {
          "type": [ "array", "null" ],
          "items": {
            "type": "string",
            "minLength": 1,
            "maxLength": 128
          },
          "maxItems": 16,
          "uniqueItems": true,
          "description": "List of Windows feature dependencies"
        },
        "WindowsLibraries": {
          "type": [ "array", "null" ],
          "items": {
            "type": "string",
            "minLength": 1,
            "maxLength": 128
          },
          "maxItems": 16,
          "uniqueItems": true,
          "description": "List of Windows library dependencies"
        },
        "PackageDependencies": {
          "type": [ "array", "null" ],
          "items": {
            "type": "object",
            "properties": {
              "PackageIdentifier": {
                "$ref": "#/definitions/PackageIdentifier"
              },
              "MinimumVersion": {
                "$ref": "#/definitions/PackageVersion"
              }
            },
            "required": [ "PackageIdentifier" ]
          },
          "maxItems": 16,
          "uniqueItems": true,
          "description": "List of package dependencies from current source"
        },
        "ExternalDependencies": {
          "type": [ "array", "null" ],
          "items": {
            "type": "string",
            "minLength": 1,
            "maxLength": 128
          },
          "maxItems": 16,
          "uniqueItems": true,
          "description": "List of external package dependencies"
        }
      }
    },

Example of Dependency which exist in the winget pkgs repo

Dependencies:
  PackageDependencies:
  - PackageIdentifier: Microsoft.VC++2015-2019Redist-x64
    MinimumVersion: 14.28.29913.0

@ghost ghost removed Validation-Installation-Error Error installing application Needs: Attention labels Jun 20, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jun 20, 2021
@ghost
Copy link

ghost commented Jun 20, 2021

Hello @ValeraFinebits,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 20, 2021
@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed labels Jun 20, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jun 20, 2021
@ghost
Copy link

ghost commented Jun 20, 2021

Hello @ValeraFinebits,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 20, 2021
@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application labels Jun 20, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jun 20, 2021
@ghost
Copy link

ghost commented Jun 20, 2021

Hello @ValeraFinebits,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 20, 2021
@OfficialEsco
Copy link
Contributor

Yeeeeh there is no way, you just have to wait for dependency support

@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application labels Jun 21, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jun 21, 2021
@ghost
Copy link

ghost commented Jun 21, 2021

Hello @ValeraFinebits,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants