Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: OtfriedCheong.Ipe version 7.2.29 #176816

Closed
wants to merge 2 commits into from

Conversation

paksnuk
Copy link

@paksnuk paksnuk commented Oct 2, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@paksnuk
Copy link
Author

paksnuk commented Oct 2, 2024

@microsoft-github-policy-service agree

@Dragon1573
Copy link
Contributor

Tip

Associate this pull request with the issue can help automatically closing issue while pull request is merged.

Edit your first comment as follows.

- - [x] Is there a linked Issue? #176757 
+ - [x] Resolve #176757 

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Oct 2, 2024
@wingetbot
Copy link
Collaborator

=== manifests\o\OtfriedCheong\Ipe\7.2.29 ===
Missing Properties value based on version 7.2.28:
ReleaseDate

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@Dragon1573
Copy link
Contributor

Manually verified in Windows Sandbox. It seems this package can't be launched by symbolic links 😞

image

@paksnuk
Copy link
Author

paksnuk commented Oct 2, 2024

I don't know how to debug this, but I can launch the app using the symlink successfully via double-click on Explorer or via the start menu (run command, not a start menu link). Thus the functionality provided by the symlink might be incomplete, but definitely helpful.
Also, please note that this is not a regression.

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Oct 2, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\ipe.exe returned exit code: -1073741515
Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\ipepresenter.exe returned exit code: -1073741515

Automated error analysis suggests -1073741515 may mean STATUS_DLL_NOT_FOUND - possibly due to a dependency on Microsoft.VCRedist.2015+.x64 (or .x86).

(Automated response - build 896.)

@paksnuk
Copy link
Author

paksnuk commented Oct 3, 2024

The dll issue also occurs with the current winget version. If this is an issue with accepting this PR, I think removing the old package is the way to go forward. Otherwise, users will download a version with the same issue, that is also outdated.

@stephengillie stephengillie added the zip-binary Depends on library files that aren't available via symlink label Oct 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Oct 3, 2024
@Trenly
Copy link
Contributor

Trenly commented Dec 3, 2024

@paksnuk - Support for zipped binaries has now been added and is available in the pipelines. This will require you to update your submission to ManifestVersion: 1.9.0 and set ArchiveBinariesDependOnPath: true in the installer node. To keep things clean, this PR is being closed. Please submit a new PR for the latest version of this package. Thank you for your contributions!

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. New-Manifest Validation-Executable-Error zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: Ipe
5 participants