Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: LesFerch.WinSetView version 2.99 #175473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Akaizoku
Copy link
Contributor

@Akaizoku Akaizoku commented Sep 27, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 27, 2024
@stephengillie stephengillie added the zip-binary Depends on library files that aren't available via symlink label Sep 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Sep 27, 2024
@stephengillie
Copy link
Collaborator

image

As with previous versions, this package depends on relative links, which don't currently work with symlinks.

@Akaizoku
Copy link
Contributor Author

@stephengillie, I must say that it does appear to work as expected on my machine running Windows 11 build 22631.4169.

When does the error occur?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 30, 2024
@stephengillie stephengillie removed the Validation-Completed Validation passed label Oct 3, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Oct 3, 2024

The package itself installs and launches normally. The issue is that symlinks are used instead of LNK files, and when the application is launched from these, it uses their location as the relative directory. Applications which are built with relative references to DLLs and other files aren't able to find these files, and so can't operate correctly. There might be a fix on the way soon, I have heard.

Edit: Punctuation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. New-Package zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants