Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiwix JS Windows v1.3.2.0 #16135

Merged
1 commit merged into from
Jun 4, 2021
Merged

Conversation

Jaifroid
Copy link
Contributor

@Jaifroid Jaifroid commented Jun 4, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jun 4, 2021

CLA assistant check
All CLA requirements met.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Jaifroid
Copy link
Contributor Author

Jaifroid commented Jun 4, 2021

There is another submission that has been opened by @oxygen-dioxide, but it uses a permalink for the package that will create versioning issues. I have asked @oxygen-dioxide to close that PR in favour of this one. I am the developer of Kiwix JS Windows -- see the GitHub repo https://github.com/kiwix/kiwix-js-windows , and I can ensure that this Repo is updated as part of the build toolchain for Kiwix JS Windows. Thank you.

EDIT: Other PR now closed.

@Jaifroid Jaifroid mentioned this pull request Jun 4, 2021
5 tasks
@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 4, 2021
@Jaifroid
Copy link
Contributor Author

Jaifroid commented Jun 4, 2021

The other submission PR has now been closed, so there is no obstacle to merging this PR: Thank you.

@Jaifroid
Copy link
Contributor Author

Jaifroid commented Jun 4, 2021

Info for reviewer:

@ghost ghost added Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed labels Jun 4, 2021
@ghost
Copy link

ghost commented Jun 4, 2021

Hello @msftbot[bot]!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d9d3fd3 into microsoft:master Jun 4, 2021
@denelon
Copy link
Contributor

denelon commented Jun 4, 2021

@Jaifroid the wingetcreate tool is an early preview. Many other fields might add value for your package like "Tags" and "Moniker".

@Jaifroid Jaifroid deleted the Kiwix-JS-Windows-v1.3.2.0 branch June 5, 2021 08:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants