Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiriformSoftware.Speccy version 1.32.0.774 #15041

Merged
1 commit merged into from
May 31, 2021
Merged

PiriformSoftware.Speccy version 1.32.0.774 #15041

1 commit merged into from
May 31, 2021

Conversation

OyePradumya
Copy link
Contributor

@OyePradumya OyePradumya commented May 31, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@OfficialEsco
Copy link
Contributor

This information is wrong.
image

@OyePradumya
Copy link
Contributor Author

This information is wrong.
image

image
you are wrong

@OfficialEsco
Copy link
Contributor

The Version inside the app does not match the ARP information.
You are ruining the manifest.

@OyePradumya
Copy link
Contributor Author

The Version inside the app does not match the ARP information.
You are ruining the manifest.

the version is mentioned on the official site

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 31, 2021
@ghost
Copy link

ghost commented May 31, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented May 31, 2021

Hello @OyePradumya,
Validation has completed.

@ghost ghost merged commit f10581b into microsoft:master May 31, 2021
@OfficialEsco
Copy link
Contributor

OfficialEsco commented May 31, 2021

The Version inside the app does not match the ARP information.
You are ruining the manifest.

the version is mentioned on the official site

WinGet does not look at the Version on the Official Site or inside the App.
Are you like trying to teach me how WinGet works without knowing how it works?

@OyePradumya
Copy link
Contributor Author

The Version inside the app does not match the ARP information.
You are ruining the manifest.

the version is mentioned on the official site

WinGet does not look at the Version on the Official Site or inside the App.
Are you like trying to teach me how WinGet works without knowing how it works?

i know that .. i hav mentioned version number by myself

@OyePradumya OyePradumya deleted the autogenerated/PiriformSoftware.Speccy/4a7f653c-6f5a-46ff-9034-d69c9122b72c branch May 31, 2021 11:29
@OfficialEsco
Copy link
Contributor

OfficialEsco commented May 31, 2021

You do not know how WinGet works, please stop submitting PRs before you break more stuff.
Please educate your self on how to use GitHub and WinGet.

ghost pushed a commit that referenced this pull request May 31, 2021
@OyePradumya
Copy link
Contributor Author

You do not know how WinGet works, please stop submitting PRs before you break more stuff.
Please educate your self on how to use GitHub and WinGet.

are you the developer of winget? what's your problem? i am reverting back the wrong pr and creating new PR with proper info

@OfficialEsco

This comment has been minimized.

@OyePradumya
Copy link
Contributor Author

You do not know how WinGet works, please stop submitting PRs before you break more stuff.
Please educate your self on how to use GitHub and WinGet.

are you the developer of winget? what's your problem? i am reverting back the wrong pr and creating new PR with proper info

Ahh no i am just a Package Maintainer since day one with 800+ submissions.
My problem is that you are fucking up the Repo with your incorrect information.

I am only creating PR with official info on the official site. You can't deny the info on official website

@OfficialEsco
Copy link
Contributor

I am only creating PR with official info on the official site. You can't deny the info on official website

As i've said earlier, the information on the website or inside the app DOES NOT MATTER, WinGet is INTEGRATED with Windows, WinGet gets its information from WINDOWS.

You DELETED the Manifest with the correct information WITHOUT knowledge of how WinGet WORKS.

@OyePradumya
Copy link
Contributor Author

I am only creating PR with official info on the official site. You can't deny the info on official website

As i've said earlier, the information on the website or inside the app DOES NOT MATTER, WinGet is INTEGRATED with Windows, WinGet gets its information from WINDOWS.

You DELETED the Manifest with the correct information WITHOUT knowledge of how WinGet WORKS.

if you feel so then kindly ban me from creating new PRs

@OfficialEsco
Copy link
Contributor

OfficialEsco commented May 31, 2021

Ok genius, so its time to test your manifest.
Install Speccy 1.31 on a VM https://download.ccleaner.com/spsetup131.exe
Do winget source update then do winget upgrade do you see a upgrade? Nope.
Ahh do winget list on your own system, is the Speccy ID PiriformSoftware.Speccy instead of Speccy? No its not because the information is wrong.

Maybe there is something wrong with Speccy
Lets install Piriform Defraggler 2.21 https://download.ccleaner.com/dfsetup222.exe
do winget upgrade hmm, seems like 2.21 is installed and we can upgrade to 2.22
lets then also do winget list ahhhh the ID appears to be Piriform.Defraggler

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants