Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Geeks3D.FurMark version 1.38.1.0 #141766

Conversation

Exorcism0666
Copy link
Contributor

@Exorcism0666 Exorcism0666 commented Mar 2, 2024

Pull request has been created with komac v2.1.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Mar 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 2, 2024
Copy link
Contributor

@fancybody fancybody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

….yaml

Co-authored-by: fancybody <87397831+fancybody@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested labels Mar 2, 2024
@Exorcism0666
Copy link
Contributor Author

For moderators

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

Warning

With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

Important

Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください!

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Mar 2, 2024
@wingetbot
Copy link
Collaborator

=== manifests\g\Geeks3D\FurMark\1.38.1.0 ===
Missing Properties value based on version 1.37.2.0:
ReleaseNotes
ReleaseNotesUrl

@og-mrk
Copy link
Contributor

og-mrk commented Mar 5, 2024

Hello @Exorcism0666 ,

=== manifests\g\Geeks3D\FurMark\1.38.1.0 ===
Missing Properties value based on version 1.37.2.0:
ReleaseNotes
ReleaseNotesUrl

Please update your manifest metadata according to the response by @wingetbot .

Thanks for your contribution to this project.

@stephengillie
Copy link
Collaborator

Hi @og-mrk,

Other community members have discussed various properties such as the ones you've quoted. These two properties are generally considered less important than other properties, and the consensus was to not block when they are missing.

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Domain

@wingetbot
Copy link
Collaborator

Commenter does not have sufficient privileges for PR 141766

@stephengillie
Copy link
Collaborator

Completing validation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 7, 2024
@stephengillie
Copy link
Collaborator

Reset approval workflow.

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Moderator-Approved One of the Moderators has reviewed and approved this PR Manifest-Metadata-Consistency labels Mar 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 7, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 7, 2024
@stephengillie stephengillie merged commit 48b95ca into microsoft:master Mar 7, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Exorcism0666 Exorcism0666 deleted the Geeks3D.FurMark-1.38.1.0-D19D26476E674C6BAF681E8273B9A666 branch March 8, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed Validation-Domain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Issue]: Geeks3D.FurMark
5 participants