Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AUTHORING_MANIFESTS.md #141399

Conversation

stephengillie
Copy link
Collaborator

@stephengillie stephengillie commented Feb 29, 2024

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Add pre-release advice section, and a few small updates.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Feb 29, 2024
@wingetbot wingetbot added the Validation-Merge-Conflict Package could not be tested due to merge conflict. label Feb 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 29, 2024
@exoosh
Copy link
Contributor

exoosh commented Feb 29, 2024

This looks great. Thank you!

AUTHORING_MANIFESTS.md Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Merge-Conflict Package could not be tested due to merge conflict. labels Mar 2, 2024
@stephengillie
Copy link
Collaborator Author

I believe the merge conflict is because I accidentally edited a line break into my main branch on line 47, before making this fork. I'm not sure how to fix this, and any advice is welcome.

@wingetbot wingetbot added the Validation-Merge-Conflict Package could not be tested due to merge conflict. label Mar 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 6, 2024
@stephengillie stephengillie force-pushed the winget-pkgs-AUTHORING-MANIFESTS-md branch from 2e38cd7 to fb56c37 Compare March 7, 2024 03:36
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. labels Mar 7, 2024
Copy link
Contributor

Hello @stephengillie,

Sorry we cannot process 141399 because you are changing validation-pipeline.yaml. Please remove that file from your PR. If you would like to discuss changes to validation-pipeline.yml, please file an issue.

Template: msftbot/pipelineModified

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Unexpected-File Validation-Merge-Conflict Package could not be tested due to merge conflict. labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants