Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incus CLI version 0.4.0 / x64 & arm64 #131752

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Incus CLI version 0.4.0 / x64 & arm64 #131752

merged 1 commit into from
Dec 28, 2023

Conversation

nunix
Copy link
Contributor

@nunix nunix commented Dec 24, 2023 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@nunix nunix changed the title Incus CLI version 0.4.0 Incus CLI version 0.4.0 / x64 & arm64 Dec 24, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 24, 2023
@stephengillie
Copy link
Collaborator

Manual Validation ended with:

9:38:47 AM:
2023-12-27 09:38:46.135 [FAIL] Installer failed security check. Url: https://github.com/lxc/incus/releases/download/v0.4.0/bin.windows.incus.x86_64.exe Result: 0x80004005

(Automated response - build 489.)

@stephengillie
Copy link
Collaborator

Hi @nunix,

The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.

@stephengillie stephengillie added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Dec 27, 2023
@nunix
Copy link
Contributor Author

nunix commented Dec 27, 2023

@stephengillie hi, thanks a lot for the heads-up and as I'm "just" a community member for Incus, let me tag the right persons to have a look: @stgraber @brauner

@stgraber
Copy link

Yeah, almost certainly a false positive.

Those upstream binaries are built on a clean Linux system so not much opportunity to pick any malware :)

I remember us occasionally tripping one of the many checks on the Chocolatey side too and they always end up letting it through after a manual check.

@stephengillie stephengillie self-assigned this Dec 28, 2023
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Dec 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 8565145 into microsoft:master Dec 28, 2023
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 28, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

nunix added a commit to nunix/incus that referenced this pull request Jan 19, 2024
@nunix
Updates Windows install with Winget instructions
e600471 
Incus has now a [winget package](microsoft/winget-pkgs#131752) available and the Windows installation docs have been updated with the instructions to install Incus with winget.

ps: I tried to used nested tabs, but the result was not good, so that's why the instructions are stacked.

ps2: while running the `make doc` from Ubuntu on WSL (what else?), I came across a package missing: `python3.10-venv`. Nothing critical, more a FYI.
@nunix nunix mentioned this pull request Jan 19, 2024
Merged
nunix added a commit to nunix/incus that referenced this pull request Jan 20, 2024
@nunix
Updates Windows install with Winget instructions
9055b07 
Incus has now a [winget package](microsoft/winget-pkgs#131752) available and the Windows installation docs have been updated with the instructions to install Incus with winget.

ps: I tried to used nested tabs, but the result was not good, so that's why the instructions are stacked.

ps2: while running the `make doc` from Ubuntu on WSL (what else?), I came across a package missing: `python3.10-venv`. Nothing critical, more a FYI.

Signed-off-by: Nuno do Carmo nuno.carmo@suse.com
stgraber pushed a commit to nunix/incus that referenced this pull request Jan 20, 2024
@nunix @stgraber
doc: Updates Windows install with Winget instructions
23e8e2f 
Incus has now a [winget package](microsoft/winget-pkgs#131752) available
and the Windows installation docs have been updated with the instructions to install Incus with winget.

PS: I tried to used nested tabs, but the result was not good, so that's why the instructions are stacked.
PS2: While running the `make doc` from Ubuntu on WSL (what else?), I came across a package missing: `python3.10-venv`. Nothing critical, more a FYI.

Signed-off-by: Nuno do Carmo <nuno.carmo@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nunix @wingetbot @stephengillie @stgraber