Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tgstation.Server version 5.14.0 #117892

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Tgstation.Server version 5.14.0 #117892

merged 2 commits into from
Aug 24, 2023

Conversation

Cyberboss
Copy link
Contributor

@Cyberboss Cyberboss commented Aug 23, 2023 •
edited
Loading

Automated Pull Request

This pull request was generated by our deployment pipeline as a result of the release of tgstation-server-v5.14.0. Validation was performed as part of the process.

The user account that created this pull request is available to correct any issues.

We would like to be verified as the publisher of this software but we cannot find documentation on how to do so.

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
    • This PR is generated as a direct result of a new release of tgstation-server this should be impossible
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
    • Validation is performed as a prerequisite to deployment.
  • Have you tested your manifest locally with winget install --manifest <path>?
    • Manifest installation and uninstallation is performed as a prerequisite to deployment.
  • Does your manifest conform to the 1.5 schema?

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdanish-kh
Copy link
Contributor

We would like to be verified as the publisher of this software but we cannot find documentation on how to do so.

@Cyberboss #100 is being worked on; It's pending on the business process for it to be finalized. You would be able to take control of the package once that's complete. Right now, the hope is that if you integrate automated CI/CD submission (as you've done here), other submissions for this package would eventually slow down/stop

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 23, 2023
@microsoft-github-policy-service
Copy link
Contributor

Cyberboss,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service
Copy link
Contributor

Hello @Cyberboss,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Aug 23, 2023
@Cyberboss @mdanish-kh
Correcting manifest issues
53fab2f 
Co-authored-by: Muhammad Danish <mdanishkhdev@gmail.com>
auto-merge was automatically disabled August 23, 2023 23:22

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. labels Aug 23, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 24, 2023
@microsoft-github-policy-service
Copy link
Contributor

Cyberboss,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit e45fdcc into microsoft:master Aug 24, 2023
7 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 24, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Cyberboss
Copy link
Contributor Author

Was about to take care of the legacy rogue DisplayVersions and ProductCodes but I see you already have @mdanish-kh, appreciated.

@Cyberboss Cyberboss deleted the Tgstation.Server-5.14.0-4f59a5bd-613d-461b-80f2-d1200ba76ebb branch August 28, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdanish-kh mdanish-kh mdanish-kh requested changes

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cyberboss @wingetbot @mdanish-kh @stephengillie