-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: Talkdesk.WorkspacesMSI version 1.10.0.2504 #111633
New package: Talkdesk.WorkspacesMSI version 1.10.0.2504 #111633
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@microsoft-github-policy-service agree |
Hello @1eyeITguy, One or more of the installer URLs doesn't appear valid. This may happen for sites with policies prohibiting distribution or use by third parties. This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR. Template: msftbot/validationError/urls/domain |
Sorry, I'm not sure how to provide validation for the URL. This is my first time contributing here. The site I've received the download link from is https://talkdesk.mytalkdesk.com/atlas/download, and downloading the .MSI package. It get's if from the URL in the manifest. Also it's the same URL in the Talkdesk.Talkdesk package that is older and the .EXE version. |
manifests/t/Talkdesk/WorkspacesMSI/1.10.0.2504/Talkdesk.WorkspacesMSI.locale.en-US.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because PackageUrl find the download link from that website during validation.
Hello @1eyeITguy, The package manager bot determined changes have been requested to your PR. Template: msftbot/changesRequested |
@wingetbot waivers Add Validation-Domain |
/AzurePipelines run |
No commit pushedDate could be found for PR 111633 in repo microsoft/winget-pkgs |
/AzurePipelines run |
No commit pushedDate could be found for PR 111633 in repo microsoft/winget-pkgs |
/AzurePipelines run |
No commit pushedDate could be found for PR 111633 in repo microsoft/winget-pkgs |
…acesMSI.locale.en-US.yaml Co-authored-by: Brandon Wan <brandonwanhuansheng@gmail.com>
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
1eyeITguy, The check-in policies require a moderator to approve PRs from the community. Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission. Template: msftbot/requiresApproval/moderator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be placed under the existing package Talkdesk.Talkdesk
Hello @1eyeITguy, The package manager bot determined changes have been requested to your PR. Template: msftbot/changesRequested |
Pull request was closed
Hello @Trenly, I first was thinking that as well. However, the MSI package of this application does have a difference over the .EXE version that is in the Talkdesk.Talkdesk package. The .EXE version has a self-updating mechanism built in, and the .MIS does not. It's a manual update for organizations that want to control when the application updates. That's why I thought it would be better to have it in a different package that calls out it's the .MSI version. |
I see the .MSI installer was added as a installerType in the manifest of Talkdesk.Talkdesk. How do you specify to use the .MSI over the .EXE? I don't see that in any documentation, and "winget install Talkdesk.Talkdesk --installertype wix" did not work. |
|
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: codeflow:open?pullrequest=#111633