Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Osu! 2020.523.0 #1067

Merged
1 commit merged into from
Jul 22, 2020
Merged

Add Osu! 2020.523.0 #1067

1 commit merged into from
Jul 22, 2020

Conversation

latere-a-latere
Copy link
Contributor

@latere-a-latere latere-a-latere commented May 25, 2020 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 25, 2020
@ghost ghost assigned denelon May 25, 2020
@ghost
Copy link

ghost commented May 25, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Error General Error during testing. Requires we provide comment to author. label May 28, 2020
@ghost
Copy link

ghost commented May 28, 2020

MarNicGit An issue was identified during the manual review, and the PR request cannot be approved. Please see comments for more information.
Please address the issue and resubmit, or if you disagree with this resolution, please raise an issue and flag this PR for further discussion.

@ghost ghost assigned latere-a-latere May 28, 2020
@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels May 28, 2020
@KevinLaMS
Copy link
Contributor

It appeared to install and uninstall correctly. However running the app did nothing. What am I mising? Thanks.

@latere-a-latere
Copy link
Contributor Author

@KevinLaMS After doing some research and trying installing it myself in the Win10 Dev environment, it appears that the application fails to launch if the system either runs off an Intel GPU or if it runs off the GDI Generic driver. (which is the case of the win10 dev vm)

Do any of these two reasons apply to you? Launching the game on a system with a dedicated GPU (my desktop with an RX5700XT) doesn't seem to give any problems whatsoever.

Issues I've found referencing this problem:
ppy/osu#5585
ppy/osu#4235
ppy/osu#3025
ppy/osu#6585
ppy/osu#6496

@ghost ghost removed the Needs: author feedback label May 30, 2020
@latere-a-latere latere-a-latere mentioned this pull request Jun 1, 2020
Closed
@KevinLaMS KevinLaMS added Validation-Completed Validation passed and removed Validation-Error General Error during testing. Requires we provide comment to author. labels Jul 22, 2020
@ghost
Copy link

ghost commented Jul 22, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Jul 22, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 99befb1 into microsoft:master Jul 22, 2020
@aeongdesu aeongdesu mentioned this pull request Feb 28, 2021
Merged
4 tasks
@aeongdesu aeongdesu mentioned this pull request Mar 13, 2021
Merged
4 tasks
@latere-a-latere latere-a-latere deleted the Add-Osu!-2020.523.0 branch May 13, 2021 22:01
@latere-a-latere latere-a-latere mentioned this pull request May 14, 2021
Merged
@denelon denelon mentioned this pull request May 14, 2021
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@latere-a-latere latere-a-latere

@denelon denelon

Labels
Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@latere-a-latere @wingetbot @KevinLaMS @denelon