Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDE.Elisa version 23.04.00 #105917

Conversation

sarvex
Copy link
Contributor

@sarvex sarvex commented May 4, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label May 4, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @sarvex,

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 4, 2023
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -2145844844
2023-05-04 05:23:55.703 [CORE] DeliveryOptimization error: 0x80190194, extended error: 0x00000000
2023-05-04 05:23:55.704 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\DODownloader.cpp(289)\WindowsPackageManager.dll!00007FF9D9321EFD: (caller: 00007FF9D93227D0) Exception(1) tid(d5c) 80190194 Not found (404).
2023-05-04 05:23:59.285 [CORE] Download request failed. Returned status: 404
2023-05-04 05:23:59.285 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Downloader.cpp(67)\WindowsPackageManager.dll!00007FF9D92E1D0B: (caller: 00007FF9D92E2129) Exception(2) tid(d5c) 80190194 Not found (404).
2023-05-04 05:23:59.364 [CLI ] Failed to download, waiting a bit and retry. Url: https://binary-factory.kde.org/view/Windows%2064-bit/job/Elisa_Release_win64/lastSuccessfulBuild/artifact/elisa-23.04.0-1488-windows-cl-msvc2019-x86_64.exe
2023-05-04 05:24:08.478 [CORE] DeliveryOptimization error: 0x80190194, extended error: 0x00000000
2023-05-04 05:24:08.478 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\DODownloader.cpp(289)\WindowsPackageManager.dll!00007FF9D9321EFD: (caller: 00007FF9D93227D0) Exception(3) tid(d5c) 80190194 Not found (404).
2023-05-04 05:24:11.212 [CORE] Download request failed. Returned status: 404
2023-05-04 05:24:11.212 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Downloader.cpp(67)\WindowsPackageManager.dll!00007FF9D92E1D0B: (caller: 00007FF9D92E2129) Exception(4) tid(d5c) 80190194 Not found (404).
2023-05-04 05:24:11.256 [CLI ] Caught wil::ResultException: D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Downloader.cpp(67)\WindowsPackageManager.dll!00007FF9D92E1D0B: (caller: 00007FF9D92E2129) Exception(4) tid(d5c) 80190194 Not found (404).

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 5, 2023
Co-authored-by: Stephen Gillie <114952565+stephengillie@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 5, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label May 5, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @sarvex,

I am sorry to report that the Sha256 Hash does not match the installer. This may be caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

Template: msftbot/validationError/installers/hashMismatch

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 5, 2023
@BrandonWanHuanSheng
Copy link
Contributor

BrandonWanHuanSheng commented May 5, 2023

Does it have alternate url because that link https://binary-factory.kde.org/view/Windows%2064-bit/job/Elisa_Release_win64/lastSuccessfulBuild/artifact/elisa-23.04.0-1489-windows-cl-msvc2019-x86_64.exe is determine to be unstable, it might damage the project.

@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label May 5, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label May 5, 2023
@wingetbot wingetbot added the Error-Installer-Availability The installer was not available to validate (HTTP Issue) label May 5, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @sarvex,

When processing this package, the URL to the installer returned a 404 error or was determined to be invalid.

Please update the URL and hash at your convenience and resubmit your PR.

Template: msftbot/validationError/urls/404

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 5, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Error-Installer-Availability The installer was not available to validate (HTTP Issue) label May 5, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label May 5, 2023
@sarvex
Copy link
Contributor Author

sarvex commented May 5, 2023

@stephengillie is there a solution to this problem, it seems KDE is building the stable release everyday and updating the build version

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label May 5, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @sarvex,

I am sorry to report that the Sha256 Hash does not match the installer. This may be caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

Template: msftbot/validationError/installers/hashMismatch

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 5, 2023
@stephengillie
Copy link
Collaborator

stephengillie commented May 5, 2023

@stephengillie is there a solution to this problem, it seems KDE is building the stable release everyday and updating the build version

Ah - there are 2 solutions for this:

  • Locate the stable release and use that here instead. This is the preferred solution.
  • Have an automated process provide a daily PR to update the manifest.

@sarvex
Copy link
Contributor Author

sarvex commented May 5, 2023

  • Locate the stable release and use that here instead. This is the preferred solution.
    Tired and failed.
  • Have an automated process provide a daily PR to update the manifest.
    Is there a framework for such a script with support of declarative programming. I am coming from scoop where such a support exists

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 5, 2023
@stephengillie
Copy link
Collaborator

  • Have an automated process provide a daily PR to update the manifest.

Is there a framework for such a script with support of declarative programming. I am coming from scoop where such a support exists

A couple of implementations exist - Wingetbot checks many packages daily, to ensure the package is still available and that the hash still matches. Several users have written similar automation for their own scripts.
These are usually based on one of the community manifest programs, such as YAMLCreate, Wingetcreate, or Komac. Some may be more suitable to scripting in Scoop or other languages than others. Or feel free to create your own manifest creation tool if you like - here is the manifest schema.

@sarvex
Copy link
Contributor Author

sarvex commented May 5, 2023

@stephengillie there seams to a feature request under development for this #500

@stephengillie
Copy link
Collaborator

@stephengillie there seams to a feature request under development for this #500

Nice find. Down the page is mentioned WinGet Releaser, which might be an automation tool similar to what you're looking for.

@sarvex sarvex closed this May 5, 2023
@sarvex
Copy link
Contributor Author

sarvex commented May 5, 2023

@stephengillie WinGet Releaser, is for project owners and required github action to commit run the github workflow. I think it is better to wait for #500 to be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Attention This work item needs to be reviewed by a member of the core team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants