Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMPlex.VMPlex version 1.0.0.11 #102646

Conversation

jxy-s
Copy link
Contributor

@jxy-s jxy-s commented Apr 16, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jxy-s
Copy link
Contributor Author

jxy-s commented Apr 16, 2023

@microsoft-github-policy-service agree

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 16, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 16, 2023 19:21
@microsoft-github-policy-service
Copy link
Contributor

jxy-s,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@stephengillie
Copy link
Collaborator

Manual Validation failed with:

12:25:02 PM: Application: VMPlex.exe
CoreCLR Version: 7.0.423.11508
.NET Version: 7.0.4
Description: The process was terminated due to an unhandled exception.
Exception Info: System.Management.ManagementException: Invalid namespace
at System.Management.ThreadDispatch.Start()
at System.Management.ManagementScope.Initialize()
at System.Management.ManagementScope.Connect()
at EasyWMI.WmiScope..ctor(String nameSpace)
at VMPlex.App.CheckCapability()
at VMPlex.App.OnStartup(StartupEventArgs e)
at System.Windows.Application.<.ctor>b__1_0(Object unused)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
at System.Windows.Threading.DispatcherOperation.InvokeImpl()
at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(Object obj)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) --- End of stack trace from previous location ---
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at MS.Internal.CulturePreservingExecutionContext.Run(CulturePreservingExecutionContext executionContext, ContextCallback callback, Object state)
at System.Windows.Threading.DispatcherOperation.Invoke()
at System.Windows.Threading.Dispatcher.ProcessQueue()
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
at System.Windows.Application.RunDispatcher(Object ignore)
at System.Windows.Application.RunInternal(Window window)
at VMPlex.App.Main()

@stephengillie
Copy link
Collaborator

Hi @jxy-s,

The application installed normally, but errored when launched in a Windows 11 VM.

@jxy-s
Copy link
Contributor Author

jxy-s commented Apr 18, 2023

@stephengillie the program requires that Hyper-V is enabled and available on the system. It looks like the exception is occurring since the IMsvm_VirtualSystemManagementService likely not present on the system:
https://github.com/0xf005ba11/vmplex-ws/blob/main/VMPlex/App.xaml.cs#L34

In a future release, I can add an exception handler in that block and show a message to users.

@jxy-s
Copy link
Contributor Author

jxy-s commented Apr 18, 2023

@stephengillie we merged this fix to handle this case: 0xf005ba11/vmplex-ws#52

What are the next steps? Is it possible to have you manually validate using a machine with Hyper-V enabled?

@microsoft-github-policy-service
Copy link
Contributor

Hello @jxy-s,

This package appears to require dependencies in order to install successfully.

This PR is blocked until support for dependencies is implemented in:

Template: msftbot/blockingIssue/dependencySupport

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Apr 19, 2023
@jxy-s
Copy link
Contributor Author

jxy-s commented Apr 19, 2023

@stephengillie why was the dependencies label added? The project has no installable dependencies. Hyper-V is a Windows Feature shipped with the operating system. The users need to enable it before using VMPlex.

image

Furthermore, the package installs fine. As you assessed:

The application installed normally,

But the label indicates:

require dependencies in order to install successfully

This is simply not accurate...

@stephengillie
Copy link
Collaborator

I'm not aware of a method for the WinGet package manager to enable Windows features. If it doesn't already exist, it might be a good feature to request.

@jxy-s
Copy link
Contributor Author

jxy-s commented Apr 20, 2023

Presence of Hyper-V is not necessary for VMPlex to be installed or uninstalled from the machine. Users of this package will have the competency to understand that the underlying virtualization technically is required for the front end.

Installation and uninstallation of the VMPlex package is not affected by the presence of Hyper-V.

Can we push this release through? Or do we need to resubmit with the patch above?

@jxy-s
Copy link
Contributor Author

jxy-s commented Apr 28, 2023

Since this has gone stale, I will resubmit with the next release containing the aforementioned clarification for users.

@jxy-s jxy-s closed this Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants