-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMPlex.VMPlex version 1.0.0.11 #102646
VMPlex.VMPlex version 1.0.0.11 #102646
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@microsoft-github-policy-service agree |
jxy-s, The check-in policies require a moderator to approve PRs from the community. Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission. Template: msftbot/requiresApproval/moderator |
Manual Validation failed with:
|
Hi @jxy-s, The application installed normally, but errored when launched in a Windows 11 VM. |
@stephengillie the program requires that Hyper-V is enabled and available on the system. It looks like the exception is occurring since the In a future release, I can add an exception handler in that block and show a message to users. |
@stephengillie we merged this fix to handle this case: 0xf005ba11/vmplex-ws#52 What are the next steps? Is it possible to have you manually validate using a machine with Hyper-V enabled? |
Hello @jxy-s, This package appears to require dependencies in order to install successfully. This PR is blocked until support for dependencies is implemented in: Template: msftbot/blockingIssue/dependencySupport |
@stephengillie why was the dependencies label added? The project has no installable dependencies. Hyper-V is a Windows Feature shipped with the operating system. The users need to enable it before using VMPlex. Furthermore, the package installs fine. As you assessed:
But the label indicates:
This is simply not accurate... |
I'm not aware of a method for the WinGet package manager to enable Windows features. If it doesn't already exist, it might be a good feature to request. |
Presence of Hyper-V is not necessary for VMPlex to be installed or uninstalled from the machine. Users of this package will have the competency to understand that the underlying virtualization technically is required for the front end. Installation and uninstallation of the VMPlex package is not affected by the presence of Hyper-V. Can we push this release through? Or do we need to resubmit with the patch above? |
Since this has gone stale, I will resubmit with the next release containing the aforementioned clarification for users. |
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow