Consume all input during extract sequence #4882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Oct 15, 2024
ryfu-msft
pushed a commit
that referenced
this pull request
Oct 21, 2024
## Change When extracting a sequence, consume all (up to 1KB really) input even if it doesn't start with an escape character. This was spurred by an issue where the `peek` call was not returning (waiting for input). Pressing Enter broke it out of that wait, but other input was now at the front and blocked future attempts to extract the sequence. The best solution to this would be to move all input handling to its own dedicated thread, but that is a much larger change.
ryfu-msft
pushed a commit
that referenced
this pull request
Oct 21, 2024
## Change When extracting a sequence, consume all (up to 1KB really) input even if it doesn't start with an escape character. This was spurred by an issue where the `peek` call was not returning (waiting for input). Pressing Enter broke it out of that wait, but other input was now at the front and blocked future attempts to extract the sequence. The best solution to this would be to move all input handling to its own dedicated thread, but that is a much larger change.
ryfu-msft
pushed a commit
that referenced
this pull request
Oct 22, 2024
## Change When extracting a sequence, consume all (up to 1KB really) input even if it doesn't start with an escape character. This was spurred by an issue where the `peek` call was not returning (waiting for input). Pressing Enter broke it out of that wait, but other input was now at the front and blocked future attempts to extract the sequence. The best solution to this would be to move all input handling to its own dedicated thread, but that is a much larger change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
When extracting a sequence, consume all (up to 1KB really) input even if it doesn't start with an escape character.
This was spurred by an issue where the
peekcall was not returning (waiting for input). Pressing Enter broke it out of that wait, but other input was now at the front and blocked future attempts to extract the sequence.The best solution to this would be to move all input handling to its own dedicated thread, but that is a much larger change.
Validation
Manual confirmation that it continues to work in golden path.
Microsoft Reviewers: Open in CodeFlow