Set WindowsSdkPackageVersion to older value #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for CoCreate from the generated code
yao-msft
previously approved these changes
Oct 9, 2024
JohnMcPMS
changed the title
ryfu-msft
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Set the
WindowsSdkPackageVersionto an older, working for us version. This fixes an issue that was occurring with the latest SDK.Also:
CoCreateInstancePInvoke in Microsoft.Management.Deployment.Projection rather than relying on the on provided by CsWinRT (which was no longer compiling after the update).partialto a number of classes that will need it when we eventually do move to a newer CsWinRTFuture maintainer note: Set
CsWinRTCcwLookupTableGeneratorEnabledto false to prevent needing to pull in WinRT.Runtime before we have our assembly resolver set up yet.Microsoft Reviewers: Open in CodeFlow