Fix PATH issue for archive containing nested portables with binary dependencies #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
approved these changes
Sep 18, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2711
Changes:
Added a new boolean field to the installer manifest called ArchiveBinariesDependOnPath. This field only applies to nested portables in an archive. When set to true, the portable installer will skip creating a symlink and automatically add the install directory to path.
No manifest validation was added since this field only affected Portables in Archive and should not be blocking even if it doesn't apply. Willing to add a manifest validation warning if needed.
Verified with an E2E test to make sure that the install directory path is added instead of the symlink directory.
Tested with this package before and after the change to make sure that the portable works as expected: microsoft/winget-pkgs#173679
Microsoft Reviewers: Open in CodeFlow