Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS Gallery tests are unreliable #4791

Merged
merged 2 commits into from
Sep 4, 2024
Merged

PS Gallery tests are unreliable #4791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d85e722
PS Gallery tests are unreliable.
JohnMcPMS Sep 4, 2024
8239ef8
Missed PS test
JohnMcPMS Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/AppInstallerCLIE2ETests/ConfigureCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public void OneTimeTeardown()
/// Intentionally has no settings to force a failure, but only after acquiring the module.
/// </summary>
[Test]
[Ignore("PS Gallery tests are unreliable.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of ignoring them, is it possible to mark them as not-breaking somehow? Like changing the Assert for a warning or something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe do Assert.Inconclusive() if we get the specific failure we are seeing

public void ConfigureFromGallery()
{
TestCommon.EnsureModuleState(Constants.GalleryTestModuleName, present: false);
Expand Down
1 change: 1 addition & 0 deletions src/AppInstallerCLIE2ETests/ConfigureShowCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public void OneTimeTearDown()
/// Simple test to confirm that a resource without a module specified can be discovered in the PSGallery.
/// </summary>
[Test]
[Ignore("PS Gallery tests are unreliable.")]
public void ShowDetailsFromGallery()
{
TestCommon.EnsureModuleState(Constants.GalleryTestModuleName, present: false);
Expand Down
8 changes: 6 additions & 2 deletions src/PowerShell/tests/Microsoft.WinGet.Configuration.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,8 @@ Describe 'Invoke-WinGetConfiguration' {
BeforeEach {
DeleteConfigTxtFiles
}


<# PS Gallery tests are unreliable.
It 'From Gallery' {
EnsureModuleState "XmlContentDsc" $false

Expand All @@ -366,6 +367,7 @@ Describe 'Invoke-WinGetConfiguration' {
$result.UnitResults[0].State | Should -Be "Completed"
$result.UnitResults[0].ResultCode | Should -Be -1978285819
}
#>

It 'From TestRepo' {
EnsureModuleState $e2eTestModule $false
Expand Down Expand Up @@ -530,7 +532,8 @@ Describe 'Start|Complete-WinGetConfiguration' {
BeforeEach {
DeleteConfigTxtFiles
}


<# PS Gallery tests are unreliable.
It 'From Gallery' {
EnsureModuleState "XmlContentDsc" $false

Expand All @@ -548,6 +551,7 @@ Describe 'Start|Complete-WinGetConfiguration' {
$result.UnitResults[0].State | Should -Be "Completed"
$result.UnitResults[0].ResultCode | Should -Be -1978285819
}
#>

It 'From TestRepo' {
$testFile = GetConfigTestDataFile "Configure_TestRepo.yml"
Expand Down
Loading