Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dependencies in the package #456

Closed
wants to merge 1 commit into from
Closed

Include dependencies in the package #456

wants to merge 1 commit into from

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Jun 24, 2020

Closes #401.

Microsoft Reviewers: Open in CodeFlow

@felipecrs felipecrs requested a review from a team as a code owner June 24, 2020 02:10
@ghost ghost added the Issue-Feature This is a feature request for the Windows Package Manager client. label Jun 24, 2020
@felipecrs felipecrs marked this pull request as draft June 24, 2020 02:13
@felipecrs
Copy link
Contributor Author

Well, I spent a big amount of hours trying to generate an Appx from the project. I was able to, but the resultant Appx doesn't seem to make winget available at the system after installing.

However, studying microsoft/terminal#5661 I noticed that the goal is to include some .dlls into the compilation. I struggled with that, and I'm don't even know how can I evaluate if it works or not, since I could not build a working Appx.

Other changes are related to unset the dependencies of the Appx manifest, and they worked as expected.

@felipecrs
Copy link
Contributor Author

felipecrs commented Jun 24, 2020

@DHowett-MSFT, I'm really sorry to bother, but I'm trying to achieve the same thing you did via microsoft/terminal#5661. I tried to understand your code and how could I port them to here, but I'm really not sure on what I'm doing. It's totally okay if you don't, but if you have any time and want to give your opinion on this I would appreciate it.

Actually, I would appreciate any help on this.

@yao-msft
Copy link
Contributor

Well, I spent a big amount of hours trying to generate an Appx from the project. I was able to, but the resultant Appx doesn't seem to make winget available at the system after installing.

The AppInstallerCliPackage project is for dev testing only. The generated appx uses wingetdev as execution alias.
By the way, there have been internal discussions on ways of distributing dependency dlls. We'll get back when a decision is made.
Thanks.

@felipecrs
Copy link
Contributor Author

The AppInstallerCliPackage project is for dev testing only. The generated appx uses wingetdev as execution alias.

Awesome! The wingetdev was all I need! I suggest to include it in the documentation if it's not already.

@felipecrs
Copy link
Contributor Author

Believe you or not, I was able to use wingetdev without the VCLibs dependencies with the package created by this PR.

Take a look (click on the GIF to see it in full quality):
u8Z39jxm0o

@JohnMcPMS
Copy link
Member

Closing as this as it has been in draft the entire time (almost its 🍰 ) and we now have VS publishing the framework packages for easier consumption.

@JohnMcPMS JohnMcPMS closed this Jun 17, 2021
@felipecrs felipecrs deleted the appx branch June 17, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish WinGet as an MSIX with dependencies included
3 participants