Ignore corrupted source data #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Mar 20, 2024
ryfu-msft
pushed a commit
to ryfu-msft/winget-cli
that referenced
this pull request
Mar 25, 2024
Rather than a failure here, we will treat corrupt source data as simply empty. The only recourse the user currently has is to delete it anyway, and COM callers have no means to mitigate it.
ryfu-msft
pushed a commit
to ryfu-msft/winget-cli
that referenced
this pull request
Mar 25, 2024
Rather than a failure here, we will treat corrupt source data as simply empty. The only recourse the user currently has is to delete it anyway, and COM callers have no means to mitigate it.
ryfu-msft
added a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Rather than a failure here, we will treat corrupt source data as simply empty. The only recourse the user currently has is to delete it anyway, and COM callers have no means to mitigate it.
Validation
Regression tests.
Microsoft Reviewers: Open in CodeFlow