Add additional admin setting to match security related group policies #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryfu-msft
reviewed
Dec 15, 2022
| @@ -5,6 +5,7 @@ | |||
| #include "winget/Archive.h" | |||
| #include "winget/Filesystem.h" | |||
There was a problem hiding this comment.
Nit: Should these also use <>? I can fix when I create the PR for removing zip experimental feature
ryfu-msft
reviewed
Dec 15, 2022
| @@ -27,7 +28,8 @@ namespace AppInstaller::CLI::Workflow | |||
| } | |||
| else | |||
| { | |||
| if (context.Args.Contains(Execution::Args::Type::IgnoreLocalArchiveMalwareScan)) | |||
| if (context.Args.Contains(Execution::Args::Type::IgnoreLocalArchiveMalwareScan) && | |||
| Settings::IsAdminSettingEnabled(Settings::AdminSetting::LocalArchiveMalwareScanOverride)) | |||
There was a problem hiding this comment.
Settings::IsAdminSettingEnabled(Settings::AdminSetting::LocalArchiveMalwareScanOverride)) [](http://example.com/codeflow?start=11&length=98)
Should there be a separate elseif block for when someone includes --ignore-local-archive-malware-scan but does not have the admin setting for LocalArchiveMalwareScanOverride enabled? If so, should there be a different error message specific to admin settings?
There was a problem hiding this comment.
This message is handled in command invocation.
ryfu-msft
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added corresponding admin settings for InstallerHashOverride and LocalArchivemalwareScanOverride
Also added tests.
Microsoft Reviewers: Open in CodeFlow