Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement archive malware scan for local manifests #2566

Merged
merged 14 commits into from
Oct 7, 2022
Merged

Implement archive malware scan for local manifests #2566

merged 14 commits into from
Oct 7, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Sep 30, 2022 •
edited by ghost
Loading

Changes:

  • Added project files to build the PureLib library and integrate with our current workflow to scan archive files downloaded from local manifests.
  • Updates NOTICE.txt

Tests:

  • Added workflow tests using testhooks to verify that the correct behavior occurs if scanning fails.
  • Added a unit test to check whether a valid zip is scanned successfully.
  • Manually verified that scanning can detect malware using a bad zip file.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner September 30, 2022 21:52
yao-msft
yao-msft reviewed Oct 4, 2022
View reviewed changes
yao-msft
yao-msft approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryfu-msft ryfu-msft merged commit 1dfa17c into microsoft:master Oct 7, 2022
@ryfu-msft ryfu-msft deleted the implementPureZipScan branch February 29, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryfu-msft @yao-msft