Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental argument to open logs folder #2510

Merged
merged 6 commits into from
Sep 27, 2022

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Sep 12, 2022


Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner September 12, 2022 01:05
@Trenly Trenly changed the title Add new argument at root level to open logs folder Add new argument to open logs folder Sep 12, 2022
@Trenly Trenly changed the title Add new argument to open logs folder Add argument to open logs folder Sep 12, 2022
@denelon
Copy link
Contributor

denelon commented Sep 12, 2022

Does this argument work with any command? Does it display the help across all commands? Maybe a quick spec would make sense for this one. I'm expecting we need to think about how it would interact with the PowerShell cmdlets as well.

@Trenly
Copy link
Contributor Author

Trenly commented Sep 12, 2022

Does this argument work with any command?

Yes

Does it display the help across all commands?

Yes

Maybe a quick spec would make sense for this one. I'm expecting we need to think about how it would interact with the PowerShell cmdlets as well.

I think it would be a good consideration, but I would suggest instead speccing out all common arguments; How does verbose logs interact with the cmdlets? How does wait interact?

I also think this could be refined more in the future (hence only mentioning the linked issue, not marking it for closure) as how users interact with logs is a complex subject. I was thinking build in some minimal functionality first, then spec out a larger feature around it?

@denelon
Copy link
Contributor

denelon commented Sep 12, 2022

Maybe it should be an experimental argument initially then. It allows us to get feedback before releasing it with the GA client if we need to iterate.

@denelon
Copy link
Contributor

denelon commented Sep 12, 2022

Yes, I agree we should cover the other types of arguments as well as they relate to PowerShell.

@Trenly Trenly changed the title Add argument to open logs folder Add experimental argument to open logs folder Sep 12, 2022
@Trenly
Copy link
Contributor Author

Trenly commented Sep 12, 2022

Maybe it should be an experimental argument initially then. It allows us to get feedback before releasing it with the GA client if we need to iterate.

Made it experimental

@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft yao-msft merged commit 082b990 into microsoft:master Sep 27, 2022
@Trenly Trenly deleted the LogsArgument branch November 28, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants