Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization needed for Format Drive changes #149

Open
matthewjustice opened this issue Apr 29, 2018 · 7 comments
Open

Localization needed for Format Drive changes #149

matthewjustice opened this issue Apr 29, 2018 · 7 comments

Comments

@matthewjustice
Copy link
Contributor

matthewjustice commented Apr 29, 2018

PR #108 / commit ea0dd95 introduced several UI changes that need localization. I'm filing an issue to track this work. Let me know if we want to use a different approach for requesting localization.

Changes needed:

  • In res_zh-CN.rc, res_ja-JP.rc, and res_pl-PL.rc
    These strings were already present, but need to be updated to match the new English text shown below:
    MENUITEM "&Format Drive...", IDM_FORMAT
    MH_MYITEMS+IDM_FORMAT, "Formats a drive"
    This new string needs translation:
    IDS_FORMATSELECTDLGTITLE "Format Drive"
  • In winfile_zh-CN.dlg, winfile_ja-JP.dlg, and winfile_pl-PL.dlg
    This new dialog was added in English and needs localization:
    FORMATSELECTDLG
  • In wfdlgs3.c
    Increase the size of CCH_DLG_TITLE if the localized version of IDS_FORMATSELECTDLGTITLE is larger than 16 characters.

FYI for the various people who have been involved with translation:
@MouriNaruto @mattn @thecatkitty @craigwi

@clzls
Copy link
Contributor

clzls commented Apr 29, 2018

In zh-CN translations there seems to be no difference between "Format Drive" and "Format Disk". They are both simply called as "Format"(格式化) in Windows 10.

The translation of "Drive" and "Disk" is a totally (maybe?) mess in Simplified Chinese. There are various translations and all of them are obscure, confusing and disgusting. For example, "磁盘"(Magnetic disks) refers to "Disk" but also refers to a "Drive" in Windows 10 as it is in "Removable Drives (可移动磁盘)". "驱动器"(Driver) is another translation for "Drive", but it's a confusing word and the verbal version "驱动" is the official translation of "Driver" for hardware.

In Windows 10, a translation "磁盘分区"(Partition on Disks) is given to "Drive" in "Computer Management" while in exactly the same window "卷"(Volume) is also used for "Drive". "驱动器"(Driver) is used in Explorer and in Property dialog their type is shown as "本地磁盘"(Local Disk).

So maybe the old translation for "Format Disk" can be left unchanged.

Update: I referred to Microsoft Style Guide but nothing useful was given besides a suggested translation "U盘" for USB Drive and USB flash drive. In Microsoft Language Portal they choose "驱动器" as an official translate. But I don't think it's necessary for this project.

@clzls
Copy link
Contributor

clzls commented Apr 29, 2018

In res_zh-CN.rc, res_zh-JP.rc, and res_pl-PL.rc

A typo. It should be

..., res_ja-JP.rc, ...

It may be confusing since zh is Chinese while Japan is using Japanese ja .

And there are a lot of JAPANBEGIN and JAPANEND with outdated Japanese translations left in all .rc files for different languages. Doesn't it look strange? A careful inspection into them is required.

@mattn
Copy link
Contributor

mattn commented Apr 29, 2018 via email

@matthewjustice
Copy link
Contributor Author

@clzls - Thanks! I corrected the typo in my original post to avoid confusion. I appreciate you taking a holistic look at the appropriate translations.

@clzls
Copy link
Contributor

clzls commented Jun 6, 2018

Task status:

  • Chinese
  • Japanese (broken)
    @mattn The title of FORMATSELECTDLG(in winfile_ja-JP.dlg) is still in English now. Maybe ドライブのフォーマット? (As same as IDS_FORMATSELECTDLGTITLE)?
  • Polish

@clzls
Copy link
Contributor

clzls commented Jun 6, 2018

@mattn ...And the dialog strings don't show up fully in my high DPI PC(Maybe because of my Chinese Windows?). You may extend the width.
image

@mattn
Copy link
Contributor

mattn commented Jun 8, 2018

I'll look into it in later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants