Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add "Start PowerShell..." to File Menu #1

Closed
markekraus opened this issue Apr 7, 2018 · 9 comments
Closed

Feature Request: Add "Start PowerShell..." to File Menu #1

markekraus opened this issue Apr 7, 2018 · 9 comments
Assignees

Comments

@markekraus
Copy link

This is great! I think this could really improve several of my workflows. I'd love to see a "Start PowerShell..." option added to the start menu.

@craigwi
Copy link
Contributor

craigwi commented Apr 8, 2018

Good idea.

@craigwi
Copy link
Contributor

craigwi commented Apr 8, 2018

What shortcut key should I bind to this command? ^p ?

@craigwi craigwi self-assigned this Apr 9, 2018
@alanwei43
Copy link

alanwei43 commented Apr 9, 2018

Do you mean this ?
火钳刘明
OR
Windows + X
火钳刘明

@gbraad
Copy link

gbraad commented Apr 9, 2018

@Allen-wei I guess he meant s/start menu/file menu of winfile.exe

@DC-Shi
Copy link

DC-Shi commented Apr 9, 2018

Maybe one more Shift would change CMD to PowerShell ?

@markekraus
Copy link
Author

@Allen-wei Yes, I am very much aware of how to do this in windows and explorer and the start menu. However, my ask is for it to be added to winfile.exe's File menu where currently only starting a normal command prompt is possible. This is, after all, the winefile repository.

@craigwi if ctrl+p is not taken, then that would be awesome!

@craigwi
Copy link
Contributor

craigwi commented Apr 9, 2018

ctrl+p it is. @markekraus, check out https://github.com/Microsoft/winfile/tree/fixissue1 and let me know if that works for you. If so, I'll integrate to master.

@markekraus
Copy link
Author

@craigwi I can't speak for the powershell.exe detection as I'm not familiar with C registry APIs, but the rest LGTM!

@TrestleMonkey
Copy link

It seems there's a little bug with this (and also the "Start Cmd Shell" command) is that if nothing has been selected yet in either the tree or file list then it crashes. The call to GetSelection(...) returns NULL and this isn't checked. I guess in this case it should fall back to the current directory being shown in the selected window.

craigwi added a commit that referenced this issue Apr 9, 2018
NOTE: I'll fix the szParams buffer length issue when I fix the cmd.exe one.
@craigwi craigwi closed this as completed Apr 9, 2018
schinagl referenced this issue in schinagl/winfile Nov 15, 2022
Update suggest_ja-JP.db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants