Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative path for extension #3224

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

glandium
Copy link
Contributor

@glandium glandium commented Aug 27, 2024

In the Firefox repository, we avoid vendoring windows-rs because it's big, and instead pull it some other way. Because cargo doesn't support this kind of setup, we have a fake windows-rs crate that uses the modules from where the real windows-rs is. This falls short when the WindowsAndMessaging feature is enabled because CARGO_MANIFEST_DIR doesn't point to the real windows-rs.

In the Firefox repository, we avoid vendoring windows-rs because it's
big, and instead pull it some other way. Because cargo doesn't support
this kind of setup, we have a fake windows-rs crate that uses the
modules from where the real windows-rs is. This falls short when the
WindowsAndMessaging feature is enabled because CARGO_MANIFEST_DIR
doesn't point to the real windows-rs.
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'd like to get rid of include_ext entirely but this seems like a reasonable change for the time being.

@kennykerr kennykerr requested a review from sivadeilra August 27, 2024 18:24
@kennykerr kennykerr changed the title Use relative paths instead of deriving from CARGO_MANIFEST_DIR. Use relative path for extension Aug 27, 2024
@kennykerr kennykerr merged commit badf366 into microsoft:master Aug 27, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants