-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't compile windows
and windows-sys
in unit test mode
#3112
Conversation
Should we be seeing a reduction here? https://github.com/microsoft/windows-rs/actions/workflows/test.yml |
I certainly see a reduction locally. |
Can you illustrate? I just don't see |
What I see happening is that we spend a bunch of time compiling the I see this happening when I run |
Ah, strangely this affects 'cargo test' but not 'cargo test --all' which is what I've trained myself to do. 🤷♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There aren't any tests but there are docs.
This PR improves cycle time for running
cargo test --all
.The
windows
andwindows-sys
crates do not contain unit tests or doc tests. Cargo doesn't know that, so it compiles these two very large crates in the#[cfg(test)]
mode and wastes time scanning for doc tests.This PR simply disables unit tests and doc tests in both of these crates. This saves a significant amount of time in running tests.