-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WinRT noexcept
support
#3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
commented
Jun 5, 2024
kennykerr
commented
Jun 5, 2024
eholk
reviewed
Jun 5, 2024
eholk
previously approved these changes
Jun 5, 2024
sivadeilra
reviewed
Jun 6, 2024
7dfe20b adds interop testing against C++/WinRT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few years ago, I introduced an optimization for https://github.com/microsoft/cppwinrt that allowed methods and properties to be attributed as
noexcept
to improve call site code generation. While all WinRT methods must return anHRESULT
on the ABI,noexcept
methods always returnS_OK
and are thus infallible. This does not change the way C++ code "looks and feels" but C++/WinRT would mark such methods noexcept in the C++ sense which allows the C++ compiler to avoid a bunch of exception handling overhead at call sites, reducing code size.In Rust, the
noexcept
can further be used to avoid having tounwrap
method calls that are known to be infallible. This also reduces error handling overhead but additionally simplifies implementations and call sites as method return values may be used directly without unwrapping.The test included with this update illustrates the impact of this change. Consider the following IDL definition of an interface:
In Rust, the first batch of methods all return a
Result
while the second do not:Fixes: #2991