Fix Debug impls for COM interfaces #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 3, 2024 02:06
Currently, the Debug impl for COM interfaces shows the recursive interface chain, like so: ``` IDWriteFontFace5(IDWriteFontFace4(IDWriteFontFace3(IDWriteFontFace2(IDWriteFontFace(0xNNN))))) ``` That's not very useful. This PR trims it down to just the current interface: ``` IDWriteFontFace5(0xNNN) ```
riverar
approved these changes
Jun 3, 2024
dpaoliello
approved these changes
Jun 3, 2024
kennykerr
reviewed
Jun 4, 2024
Comment on lines
+423
to
+425
| println!("IUnknown = {iunknown:?}"); | ||
| let ifoo: IFoo = app.to_interface(); | ||
| println!("IFoo = {ifoo:?}"); |
There was a problem hiding this comment.
These are not tests. 😉 #3068
mati865
pushed a commit
to mati865/windows-rs
that referenced
this pull request
Jun 15, 2024
* Fix Debug impls for COM interfaces Currently, the Debug impl for COM interfaces shows the recursive interface chain, like so: ``` IDWriteFontFace5(IDWriteFontFace4(IDWriteFontFace3(IDWriteFontFace2(IDWriteFontFace(0xNNN))))) ``` That's not very useful. This PR trims it down to just the current interface: ``` IDWriteFontFace5(0xNNN) ``` * fix build break --------- Co-authored-by: Arlie Davis <ardavis@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Debug impl for COM interfaces shows the recursive interface chain, like so:
That's not very useful. This PR trims it down to just the current interface: