Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default rustfmt config for most crates #3064

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

sivadeilra
Copy link
Collaborator

@sivadeilra sivadeilra commented Jun 3, 2024

This uses the default rustfmt configuration for windows-core, windows-implement, and windows-interface.

Editing files that use the non-default rustfmt config (with extremely wide columns) is significantly more difficult than editing files that use the default config.

@riverar riverar changed the title Uuse default rustfmt config for most crates Use default rustfmt config for most crates Jun 3, 2024
@sivadeilra sivadeilra marked this pull request as ready for review June 3, 2024 08:20
@sivadeilra sivadeilra requested review from wravery and dpaoliello June 3, 2024 08:29
dpaoliello
dpaoliello previously approved these changes Jun 3, 2024
@sivadeilra sivadeilra force-pushed the user/ardavis/rustfmt branch from a3ec2b3 to 5349553 Compare June 3, 2024 19:16
crates/libs/targets/rustfmt.toml Outdated Show resolved Hide resolved
@sivadeilra sivadeilra merged commit 8b4a185 into microsoft:master Jun 3, 2024
90 checks passed
@sivadeilra sivadeilra deleted the user/ardavis/rustfmt branch June 3, 2024 19:44
@kennykerr
Copy link
Collaborator

It's not immediately obvious that this PR added a rustfmt-config config option to windows-bindgen - not sure I like the supportability of that. May rethink this at some point, but it does simplify formatting and readability so that's good.

mati865 pushed a commit to mati865/windows-rs that referenced this pull request Jun 15, 2024
Use the default configuration for rustfmt in all crates, except for the `windows` and `windows-sys` crates.
---------

Co-authored-by: Arlie Davis <ardavis@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants