Switch to windows-2022 hosted runners
#3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@riverar windows-rs/.github/workflows/lib.yml Line 63 in 40d35fa |
|
We could, yup. I'm not really a fan of vswhere honestly but that's me. |
|
I don't really care - just noticed that's what lib.yml does - I don't have it installed locally for some reason so I assume it doens't even come with Visual Studio. |
|
It would just be nice not to have to hardcode these paths. |
|
vswhere should always be installed with visual studio. And always in the same path: |
riverar
approved these changes
May 25, 2024
|
Thanks! |
mati865
pushed a commit
to mati865/windows-rs
that referenced
this pull request
Jun 15, 2024
Co-authored-by: Rafael Rivera <rafael@withinwindows.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to fix #3054 build issues, I'm testing whether we can switch to the latest GitHub runners so that we can build with VS 2022 rather than 2019.
I expect action.yml will also need to be "fixed" as it has some hardcoded paths.