Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow improvements #2994

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Workflow improvements #2994

merged 4 commits into from
Apr 15, 2024

Conversation

kennykerr
Copy link
Collaborator

Working on some workflow improvements to make it easier to add some needed cross-arch testing.

@kennykerr
Copy link
Collaborator Author

kennykerr commented Apr 15, 2024

These failures goes back to rust-lang/cargo#9661 and looks like there's no hope for a fix this millennium. 🥹

This reverts commit 6398aca.
@kennykerr kennykerr merged commit 95dd4de into master Apr 15, 2024
69 checks passed
@kennykerr kennykerr deleted the workflow branch April 15, 2024 19:43
@jeremyd2019
Copy link
Contributor

These failures goes back to rust-lang/cargo#9661 and looks like there's no hope for a fix this millennium. 🥹

It seemed that listing the dependency as a dependency rather than a build dependency fixed this for me (8783a1c). I don't know what other potential side-effects that might have, but the tests did pass with that change.

@kennykerr
Copy link
Collaborator Author

Thanks, will test that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants