Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash impl for HSTRING #2924

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Hash impl for HSTRING #2924

merged 2 commits into from
Mar 12, 2024

Conversation

zardini123
Copy link
Contributor

Adds Hash implementation to HSTRING.

@zardini123 zardini123 mentioned this pull request Mar 10, 2024
Closed
@kennykerr
Copy link
Collaborator

Thanks for the contribution! Please add a basic test here just to make sure we have a test that validates:

crates\tests\core\tests\hstring.rs

@zardini123
Copy link
Contributor Author

@microsoft-github-policy-service agree

@zardini123
Copy link
Contributor Author

Hi @kennykerr! Thank you for the feedback. I have created two tests to validate the API of hashing HSTRING and updated my branch.

Let me know if there is any more needed changes or feedback.

kennykerr
kennykerr approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennykerr kennykerr merged commit 6f4a726 into microsoft:master Mar 12, 2024
66 checks passed
@zardini123 zardini123 mentioned this pull request Mar 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennykerr kennykerr kennykerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zardini123 @kennykerr