Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid windows crate dependency in implement and interface macros #2917

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Mar 7, 2024

The implement and interface macros used for COM support don't need to depend on the windows crate itself, but as a consequence of how proc macros inject code it can get a little awkward since any dependencies that may be injected are the responsibility of the calling crate to provide. Still, I think this is cleaner and allows these macros to be used in more scenarios. The only real issue you may encounter when upgrading is the need to add an explicit dependency on the windows-core crate, if you don't already have one.

@kennykerr kennykerr merged commit 9cdea4e into master Mar 7, 2024
66 checks passed
@kennykerr kennykerr deleted the windows-core-macros branch March 7, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant