Avoid Result transformation for WIN32_ERROR

[kennykerr]

Much like NTSTATUS and RPC_STATUS, functions that return WIN32_ERROR often require the caller to inspect and branch based on the specific error code. Automatically transforming to a Result can make this needlessly complicated as the error code needs to be re-translated back from an HRESULT.

Callers that still want a Result or ? error propagation can simply use the ok helper as in SomeApi().ok()?.

[fgimian]

Is it worth marking WIN32_ERROR as #[must_use] @kennykerr? My only concern after upgrading to 0.54.0 is that it is now quite possible to forget to handle errors and no warnings are given about this (unlike previous versions which forced using Result values).

Cheers
Fotis

[kennykerr]

Good idea!

[fgimian]

Forgive me for a further question, but I notice various functions do still return Result types in 0.54.0, is this intentional? e.g. CloseHandle

Was this applied selectively to certain functions or should it be consistent throughout?

Thanks again mate, and keep up the great work!
Fotis

[kennykerr]

The transformation is (still) applied to functions that return HRESULT or BOOL, except under certain conditions where the original signature is preserved. In those cases, you're not really losing anything having it transformed into a Result.

[fgimian]

The transformation is (still) applied to functions that return HRESULT or BOOL, except under certain conditions where the original signature is preserved. In those cases, you're not really losing anything having it transformed into a Result.

Ah gotcha, that makes sense, thanks for the clarification 😄